1932686 - Migrate legacy JS metrics to glean

Status: RESOLVED FIXED

(Core :: XPConnect, task)

Description

[Denis Palmeiro [:denispal]]

The following metrics are not available in glean so we have no Android data for them.

GC_REASON_2
GC_SLOW_PHASE
GC_SLOW_TASK
GC_RESET_REASON
GC_NON_INCREMENTAL_REASON
GC_MINOR_REASON
GC_MINOR_REASON_LONG
GC_IS_COMPARTMENTAL
GC_BUDGET_WAS_INCREASED
GC_SLICE_WAS_LONG
GC_RESET
GC_NON_INCREMENTAL
GC_PARALLEL_MARK
GC_BUDGET_MS_2
GC_BUDGET_OVERRUN
GC_ANIMATION_MS
GC_MAX_PAUSE_MS_2
GC_MARK_GRAY_MS_2
GC_MARK_WEAK_MS
GC_TIME_BETWEEN_S
GC_TIME_BETWEEN_SLICES_MS
GC_TASK_START_DELAY_US
GC_MMU_50
GC_NURSERY_PROMOTION_RATE
GC_TENURED_SURVIVAL_RATE
GC_PARALLEL_MARK_UTILIZATION
GC_NURSERY_BYTES_2
GC_EFFECTIVENESS
GC_ZONE_COUNT
GC_ZONES_COLLECTED
GC_PRETENURE_COUNT_2
GC_MARK_RATE_2
GC_SLICE_COUNT
GC_PARALLEL_MARK_SPEEDUP
GC_PARALLEL_MARK_INTERRUPTIONS

Comment 1

[Denis Palmeiro [:denispal]]

Attachment: Bug 1932686: Migrate legacy MemoryDistribution, Percentage, and Integer JS metrics to glean using a custom distribution. r=jonco!

Comment 2

[Denis Palmeiro [:denispal]]

Attachment: Bug 1932686: Migrate boolean legacy GC metrics to glean using a labled_counter type. r=jonco!

Depends on D231644

Comment 3

[Denis Palmeiro [:denispal]]

Attachment: Bug 1932686: Migrate enumeration legacy GC metrics to glean using a labeled counter. r=jonco!,chutten!

Depends on D231645

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The component has been changed since the backlog priority was decided, so we're resetting it.
For more information, please visit BugBot documentation.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba8bd50a3a28
Migrate legacy MemoryDistribution, Percentage, and Integer JS metrics to glean using a custom distribution.  r=jonco
https://hg.mozilla.org/integration/autoland/rev/49990191195a
Migrate boolean legacy GC metrics to glean using a labled_counter type.  r=jonco
https://hg.mozilla.org/integration/autoland/rev/7d099d4bac74
Migrate enumeration legacy GC metrics to glean using a labeled counter. r=jonco,chutten

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ba8bd50a3a28
https://hg.mozilla.org/mozilla-central/rev/49990191195a
https://hg.mozilla.org/mozilla-central/rev/7d099d4bac74

Comment 7

[Florin Bilt]

(In reply to Cosmin Sabou [:CosminS] from comment #6)

https://hg.mozilla.org/mozilla-central/rev/ba8bd50a3a28
https://hg.mozilla.org/mozilla-central/rev/49990191195a
https://hg.mozilla.org/mozilla-central/rev/7d099d4bac74

Perfherder has detected a talos performance change from push 7d099d4bac7446d5bd798f813a2e78b1aefb1816.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
6%	perf_reftest_singletons tiny-traversal-singleton.html	linux1804-64-shippable-qr	e10s fission stylo webrender	988.89 -> 925.74

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 43369

For more information on performance sheriffing please see our FAQ.