1932700 - Implementation bug for popover-inside-invoker fix

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Mason Freed]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/133.0.0.0 Safari/537.36

Steps to reproduce:

This is an implementation bug for this spec PR:

https://github.com/whatwg/html/pull/10770

It fixes a corner case issue with the behavior of a popover nested inside the invoker for that popover.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::DOM: Core & HTML' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Keith Cirkel [:keithamus]]

Attachment: Bug 1932700 - Fix edge case: click events inside buttons with popover descendants r?#dom-core

Given a structure like:

<button popovertarget=foo>Activate
  <div popover id=foo>Clicking me shouldn't close me</div>
</button>

With the popover open, clicking the popover will propagate a click
upward to the button, which will close the button. This change ensures
that the original target is checked, and if it is a
ShadowIncludingDescendantOf the button then the popover behaviour is not
invoked.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/cb4a19d822e8
https://hg.mozilla.org/integration/autoland/rev/c966ce3fbecc
Fix edge case: click events inside buttons with popover descendants r=dom-core,smaug

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/54188 for changes under testing/web-platform/tests

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c966ce3fbecc

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot