1932753 - [wpt-sync] Sync PR 49320 - Fix leak in single-touch.html

Status: RESOLVED FIXED

(Core :: DOM: Events, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 49320 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/49320
Details from upstream follow.

Kevin Ellis <[e-mail]> wrote:

Fix leak in single-touch.html

This test could trigger leak detection since not waiting on pointerup
after all of the async tests have completed.

Actions().send() does not wait on the dispatched events to be handled.
Each async test marked itself as done once the expected event was
received. Refactored to be a promise driven test.

2 flakes out of 100 runs without the fix.
0 flakes out of 500 runs with the fix.

Bug: 40945204
Change-Id: I5468e3bc67ecdfa5c09e53a705abdcbc22024cde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6033293
Commit-Queue: Kevin Ellis \<[e-mail]>
Reviewed-by: Mustaq Ahmed \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1386408}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=b1fd645032b5d80585db77a8bb075b69a1b9368b

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 227 subtests

Status Summary

Firefox

OK : 1
PASS : 226
FAIL : 1

Chrome

OK : 1
PASS : 227

Safari

FAIL : 1
ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /touch-events/single-touch.html [wpt.fyi]
  • Verify touch events for a single touch drag operation: FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b09664e69cf
[wpt PR 49320] - Fix leak in single-touch.html, a=testonly
https://hg.mozilla.org/integration/autoland/rev/bc337a76c2d0
[wpt PR 49320] - Update wpt metadata, a=testonly

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/7b09664e69cf
https://hg.mozilla.org/mozilla-central/rev/bc337a76c2d0