1932775 - Bookmark toolbar is using tablet density on a non-convertible laptop that has a touchscreen

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: zoomed_screenshot.png

The height of the gray mouseover highlight behind the bookmarks on the bookmark toolbar is taller in Nightly 134. I'm not using a Windows tablet, but I am using a Windows 11 laptop with a built-in touchscreen and non-touchscreen external monitor.

I bisected this regression to this pushlog for bug 1819421:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=4b0a991484b8c67780c2a183776e31902561816b&tochange=bcab45db97e635a0a4e4f2c1270b610a9bdf671b

Comment 1

[Ray Kraesig [:rkraesig]]

I can reproduce locally; but to confirm that it's for the same reason, could you start Nightly with MOZ_LOG=TabletMode:5 and report the output?

Comment 2

[Ray Kraesig [:rkraesig]]

(Addendum: and, if this try-build has completed by the time you see this, also its log output and whether or not that resolves the issue.)

Comment 3

[Chris Peterson [:cpeterson]]

Here's my TabletMode log from Nightly 134.0a1 (2024-11-21)

[Parent 30188: Main Thread]: I/TabletMode TCH: 'ConvertibleSlateMode' found
[Parent 30188: Main Thread]: I/TabletMode tablet-capability heuristic: true

I'll test the try build when it's available.

Comment 4

[Chris Peterson [:cpeterson]]

I tested your try build and it looks like it fixed the regression.

Here's the TabletMode log from your try build:

[Parent 16588: Main Thread]: I/TabletMode TCH: 'ConvertibleSlateMode' found; value is 0x00000000
[Parent 16588: Main Thread]: I/TabletMode TCH: no rotation sensor
[Parent 16588: Main Thread]: I/TabletMode tablet-capability heuristic: false

Comment 5

[Ray Kraesig [:rkraesig]]

Attachment: Bug 1932775 - [1/1] Remove unreliable registry-key check r?gsvelto,#win-reviewers

The registry key in question is known to be unhelpfully present on some
non-tablet-capable devices. Given this, it's never helpful except when
the SM_CONVERTIBLESLATEMODE test would already have told us whether
the device is tablet-capable.

Remove the check entirely, except when logging.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/890347724aa2
[1/1] Remove unreliable registry-key check  r=win-reviewers,handyman

Comment 7

[Ray Kraesig [:rkraesig]]

Comment on attachment 9439414 [details]
Bug 1932775 - [1/1] Remove unreliable registry-key check r?gsvelto,#win-reviewers

This has missed the merge cutoff, so it'll need to be uplifted.

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: Tablet-mode detection was borked; without this fix Firefox 134 will incorrectly display in low-density mode on some systems.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This basically just removes the unreliable heuristic. (We check it anyway when logging, but not otherwise.)
• String changes made/needed:
• Is Android affected?: No

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/890347724aa2

Comment 9

[Donal Meehan [:dmeehan]]

Comment on attachment 9439414 [details]
Bug 1932775 - [1/1] Remove unreliable registry-key check r?gsvelto,#win-reviewers

Rejecting beta uplift request. Fx134 is still in nightly.
This has landed in time to ride the train to beta with Fx134.