193286 - Field validation errors have wrong page title

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Dave Miller [:justdave]]

Steps to reproduce:

1. look at user-error.html.tmpl
2. Observe that for the "unknown_keyword" error, title is set to "Unknown Keyword".
3. Load any bug on Landfill
4. put in "blog" as a keyword and commit the bug
Results: "blog is an unknown keyword" appears, but the title is "Bug processed"
5. hit the back button.
6. make a comment and commit
7. you should get a normal bug processed page.
8. Hit the Back button (do not hit the "back to bug xxx" link)
9. put in "blog" as a keyword and commit the bug.
Results: "blog is an unknown keyword" appears, but the title is "Mid-Air Collision!"

Basically this means that "header_done" is getting set somewhere along the way
before process_bug gets to the point of doing field validation.  If there's a
chance we could still have errors, we shouldn't be spitting out templates yet.

I'm betting the reason we've spit out a header before we got to that point is
because of change-multiple.

Probably what we need to do, take that code for spitting out the header, and
move it inside the bug change loop.  In there, we check if header_done is set
before spitting out the "bug processed" template, and if it's not, spit out the
header template first.

Or maybe even have the bug change output template do a conditional
header.html.tmpl if header_done isn't set yet and take that out of process_bug
altogether.

Comment 1

[Dave Miller [:justdave]]

Attachment: Patch v1

Comment 2

[Dave Miller [:justdave]]

mine

Comment 3

[Dave Miller [:justdave]]

Comment on attachment 114404 [details] [diff] [review]
Patch v1

header_done sucks, but there it is. :)

Comment 4

[Gervase Markham [:gerv]]

Comment on attachment 114404 [details] [diff] [review]
Patch v1

Hmm. This means that people will wait at a blank page longer rather than
waiting with a header but no mail-sent boxes. 

Still, I see no other sane option, if the status quo is considered
unacceptable.

r=gerv.

Gerv

Comment 5

[Jacob Steenhagen]

We could always use the "please wait" page for everything on supported browsers :)

Comment 6

[Dave Miller [:justdave]]

Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.177; previous revision: 1.176
done
Checking in template/en/default/bug/process/midair.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/process/midair.html.tmpl,v
 <--  midair.html.tmpl
new revision: 1.6; previous revision: 1.5
done
Checking in template/en/default/bug/process/results.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/process/results.html.tmpl,v
 <--  results.html.tmpl
new revision: 1.5; previous revision: 1.4
done