193298 - XBL doesn't deal well with ReplaceChild DOM manipulation

Status: RESOLVED FIXED

(Core :: XBL, defect)

Description

[Boris Zbarsky [:bzbarsky]]

See bug 191637 comment 41.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

was this fixed together with bug 197427? Or will bug 237566 fix it since
.replaceChild will turn into .removeChild/.insertChild

Comment 2

[Boris Zbarsky [:bzbarsky]]

I don't think this is fixed yet, no.

Comment 3

[Boris Zbarsky [:bzbarsky]]

bug 237566 probably did fix this, though.

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Most likly this is fixed now, but I don't have a firefox/thunderbird build to
test with.

Comment 5

[Boris Zbarsky [:bzbarsky]]

ccing some firefoxy folks in the hope that they can test this....

Comment 6

[Mike Connor [:mconnor]]

is there a testcase somewhere for this or do I need to do something in particular?

Comment 7

[Boris Zbarsky [:bzbarsky]]

You take the toolbar customization dialog for firefox and remove the removeChild
calls it makes right before replaceChild calls (see comment 0 of this bug and
bug 191637 comment 27 middle of comment or so).

Then you see whether the silly thing still works.  ;)

Comment 8

[Boris Zbarsky [:bzbarsky]]

I'm just gonna mark this fixed (by bug 237566).