1933008 - Unused variable in SkFontHost_cairo.cpp - an incorrect declaration in https://searchfox.org/mozilla-central/source/gfx/skia/skia/src/ports/SkFontHost_cairo.cpp#499

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[ISHIKAWA, Chiaki (I will be tied up until Dec 14 with day job events.)]

In https://searchfox.org/mozilla-central/source/gfx/skia/skia/src/ports/SkFontHost_cairo.cpp#499
there is a code

bool SkScalerContext_CairoFT::prepareGlyph(FT_GlyphSlot glyph)
{
    bool modified = false;
    if (fRec.fFlags & SkScalerContext::kEmbolden_Flag) {
        // Not FT_GlyphSlot_Embolden because we want a less extreme effect.
        mozilla_glyphslot_embolden_less(glyph);
        bool modified = true;     <---- |bool| here needs to be removed.!!!
    }
    return modified;
}

The incorrect use of |bool| on the line hides the variable in the surrounding scope.
The code was updated in Bug 1931242.

I looked at https://github.com/google/skia
and was unable to locate SkFontHost_cairo.cpp there.

So maybe this file is only mozilla M-C?

Comment 1

[Lee Salzman [:lsalzman]]

Attachment: Bug 1933008 - Fix SkScalerContext_CairoFT::prepareGlyph. r?aosmond

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a59c661a6e4
Fix SkScalerContext_CairoFT::prepareGlyph. r=aosmond

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/7a59c661a6e4