1933057 - Pass `--use-local-debuginfo` to minidump-stackwalk in mozcrash.py to use local symbols already present in binaries without requiring users to invoke `mach buildsymbols` after every build

Status: NEW

(Toolkit :: Crash Reporting, enhancement)

Description

[Andrew Sutherland [:asuth] (he/him)]

In this message in the crashreporting channel of chat.mozilla.org :gsvelto said:

Well, we could just pass --use-local-debuginfo to minidump-stackwalk and it should work out of the box
It should be just a matter of tweaking mozcrash.py. I'll give it a spin tomorrow.

Having looked at this a bit, it appears that this would obsolete the need for developers to manually run mach buildsymbols after every mach build if they want crashes in local test runs symbolicated. (Noting that until bug 1924260 is fixed, it's also necessary to manually pass --symbols-path to mach wpt to symbolicate successfully at all for wpt tests run locally.)

Comment 1

[Gabriele Svelto [:gsvelto]]

I finally figured why we haven't done this yet: I forgot to update the stackwalker we use in automation, so that needs to happen first.

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

Attachment: mozcrash-use-local.diff

(In reply to Gabriele Svelto [:gsvelto] from comment #1)

I finally figured why we haven't done this yet: I forgot to update the stackwalker we use in automation, so that needs to happen first.

I'm confused by whether https://bugzilla.mozilla.org/show_bug.cgi?id=1933629#c5 means there's still more to do or if that dependency is solved, but if there's more to do there, on the patch attached here I keyed use of the flag on the heuristic that decides we're on a local machine and that works on my local machine (but of course I have no clue what it might do to the automation).

Comment 3

[Gabriele Svelto [:gsvelto]]

The dependency is solved but since there's more to do for that bug we're leaving it open. I'm removing the dependency since this can go forward now.