1933081 - Clean up Components usage in cZ

Status: RESOLVED FIXED

(SeaMonkey :: Chat, enhancement)

Description

[Frank-Rainer Grahl (:frg)]

While doing reviews I noticed that there are still some places using the unabbreviated Components.* usage left. Quick cleanup incoming.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1933081-czcomponents-25320.patch

I left one Components.classes usage in static.js intact for better readability. If you want it out too lmk.

[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.20b1 pre
Risk to taking this patch (and alternatives if risky): trivial
String changes made by this patch: --

Comment 2

[Ian Neal]

Comment on attachment 9439579 [details] [diff] [review]
1933081-czcomponents-25320.patch

Review of attachment 9439579 [details] [diff] [review]:
-----------------------------------------------------------------

r/a=me with those addressed

::: suite/extensions/irc/js/lib/dcc.js
@@ +977,1 @@
>      this.filestream.setOutputStream(this.localFile.outputStream);

Combine into:
this.filestream = Cc["@mozilla.org/binaryoutputstream;1"]
                                .createInstance(Ci.nsIBinaryOutputStream)
                                .setOutputStream(this.localFile.outputStream);

@@ +1069,3 @@
>          this.filestream = this.filestream.createInstance(nsIBinaryInputStream);
>          this.filestream.setInputStream(this.localFile.baseInputStream);
>  

Combine this into:
this.filestream = Cc["@mozilla.org/binaryinputstream;1"]
                                .createInstance(Ci.nsIBinaryInputStream)
                                .setInputStream(this.localFile.baseInputStream);

Comment 3

[Frank-Rainer Grahl (:frg)]

Attachment: 1933081-czcomponents-1_1-25320.patch

Updated patch with review comments fixed. r/a+ from IanN retained.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/df16fa65d312
Clean up Components usage in ChatZilla. r=IanN