Move objectContains helper into command-manager.js in cZ
Categories
(SeaMonkey :: Chat, task)
Tracking
(seamonkey2.53- fixed)
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
(Whiteboard: SM2.53.20)
Attachments
(1 file)
1.56 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
|
Details | Diff | Splinter Review |
The only callers for the objectContains helper are in command-manager.js, so let's move it into that file.
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.20pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none
Updated•2 months ago
|
Comment 2•2 months ago
|
||
Comment on attachment 9439584 [details] [diff] [review]
1933086-irc-command-manager-objectContains-25320.patch
lgtm r/a+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/9f7451542cc5
Move objectContains helper into command-manager.js in cZ. r=frg
Comment 4•5 days ago
|
||
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/ecbb4cf350d5809288d468f39125b6d416bd45eb
Move objectContains helper into command-manager.js in cZ. r=frg a=frg
Description
•