Closed
Bug 1933091
Opened 1 year ago
Closed 1 year ago
Move matchObject helper into events.js in cZ
Categories
(SeaMonkey :: Chat, task)
SeaMonkey
Chat
Tracking
(seamonkey2.53+ fixed)
RESOLVED
FIXED
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
(Whiteboard: SM.2.53.20)
Attachments
(1 file)
|
4.40 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
|
Details | Diff | Splinter Review |
The only caller for matchObject helper is in events.js, so let's move the helper into that file.
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.20pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none
Attachment #9439589 -
Flags: review?(frgrahl)
Attachment #9439589 -
Flags: approval-comm-release?
|
||
Updated•1 year ago
|
|
|
||
Comment 2•1 year ago
|
||
Comment on attachment 9439589 [details] [diff] [review]
1933091-irc-events-matchObject-25320.patch
lgtm r/a+
Attachment #9439589 -
Flags: review?(frgrahl)
Attachment #9439589 -
Flags: review+
Attachment #9439589 -
Flags: approval-comm-release?
Attachment #9439589 -
Flags: approval-comm-release+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/6be825591de0
Move matchObject helper into events.js in cZ. r=frg
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
|
|
||
Comment 4•1 year ago
|
||
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/b6e0321d6b1c3cd147860f304927a5c96fbab083
Move matchObject helper into events.js in cZ. r=frg a=frg
You need to log in
before you can comment on or make changes to this bug.
Description
•