Closed Bug 1933092 Opened 2 months ago Closed 2 months ago

Move equalsObject helper into channels.js in cZ

Categories

(SeaMonkey :: Chat, task)

Tracking

(seamonkey2.53+ fixed)

RESOLVED FIXED
Tracking Status
seamonkey2.53 + fixed

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

Details

(Whiteboard: SM2.53.20)

Attachments

(1 file)

The only caller for equalsObject is in the function processOpFilterStart in channels.js, so let's move the helper into that function.

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.20pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Attachment #9439590 - Flags: review?(frgrahl)
Attachment #9439590 - Flags: approval-comm-release?
Whiteboard: SM2.53.20

Comment on attachment 9439590 [details] [diff] [review]
1933092-irc-channels-equalsObject-25320.patch

lgtm r/a+

Attachment #9439590 - Flags: review?(frgrahl)
Attachment #9439590 - Flags: review+
Attachment #9439590 - Flags: approval-comm-release?
Attachment #9439590 - Flags: approval-comm-release+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/d8bac5dda18f
Move equalsObject helper into channels.js in cZ. r=frg

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: