1933099 - Importing many items from a CalDAV server with "Offline Support" disabled can cause significant jank

Status: RESOLVED FIXED

(Calendar :: Provider: CalDAV, defect)

Description

[Geoff Lankow (:darktrojan)]

For a calendar without offline storage, when a multiget request is made and the server returns many items, each item is parsed and added to the calendar without yielding the event loop. Thunderbird would appear unresponsive during this time. It's particularly bad at start-up, as calendars without offline storage are synced as soon as they are initialised.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1933099 - Yield the event loop during CalDAV item sync. r=#thunderbird-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1da71f7d6dfb
Yield the event loop during CalDAV item sync. r=leftmostcat

Comment 3

[Geoff Lankow (:darktrojan)]

Release Note Request (optional, but appreciated)
[Why is this notable]: it should be a good start-up performance improvement for some users
[Suggested wording]: CalDAV calendars without offline support could degrade start-up performance.
[Links (documentation, blog post, etc)]:

Comment 4

[Geoff Lankow (:darktrojan)]

Comment on attachment 9439604 [details]
Bug 1933099 - Yield the event loop during CalDAV item sync. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): probably always happened
User impact if declined: start up can be slow for people who don't use offline support
Testing completed (on c-c, etc.): it landed early this week
Risk to taking this patch (and alternatives if risky): this is a simple patch, I can't see any risk

Comment 5

[Geoff Lankow (:darktrojan)]

Comment on attachment 9439604 [details]
Bug 1933099 - Yield the event loop during CalDAV item sync. r=#thunderbird-reviewers

Oh wait, never mind, this landed before the merge.