1933253 - Add card for managing preferences during onboarding

Status: RESOLVED FIXED

(Firefox for Android :: Experimentation and Telemetry, enhancement, P1)

Comment 1

[Arturo Mejia [:amejia]]

Attachment: Bug 1933253 - Add card for managing preferences during onboarding

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/78916891c9a2
Add card for managing preferences during onboarding r=android-reviewers,twhite

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/78916891c9a2

Comment 4

[Francesco Lodolo [:flod]]

<string name="onboarding_term_of_service_line_three" tools:ignore="UnusedResources,BrandUsage">To help improve the browser, Firefox sends diagnostic and interaction data to Mozilla. Manage</string>

Is this string correct? The final "Manage" without a period, with an object looks like a straggler (there is a separate string for Manage, onboarding_term_of_service_line_three_link_text).

Comment 5

[Arturo Mejia [:amejia]]

Yes, it's correct to achieve the expected UI we need to have a separate key of what needs to be highlighted.

Comment 6

[Francesco Lodolo [:flod]]

I think this specific problem came up before, and this is not going to work when the content is localized, because there is no way to guarantee consistency between the two strings.

The only safe approach is to have a placeholder to guarantee that the translation doesn't diverge (and an explanation of what's going to happen with it).

To help improve the browser, Firefox sends diagnostic and interaction data to Mozilla. %S

Even if it's not a real placeholder, we have checks to guarantee that this is not lost.

Comment 7

[Francesco Lodolo [:flod]]

Also, could you point me where the replacement happen in the code?

Comment 8

[Francesco Lodolo [:flod]]

Found the previous conversation in bug 1809972.

Comment 9

[Arturo Mejia [:amejia]]

We are doing the replacement here