1933281 - Update the algorithm to sort animation cancel event

Status: ASSIGNED

(Core :: CSS Transitions and Animations, defect)

Description

[Boris Chiou [:boris]]

Per the discussion in Bug 1923208 and the spec issue (https://github.com/w3c/csswg-drafts/issues/11064), Brian updated the spec (https://github.com/w3c/csswg-drafts/pull/11176), so now we follow the new rules to sort animation events (https://drafts.csswg.org/css-animations-2/#animation-composite-order):

When determining the composite order in order to sort animation events where either or both of the events is an animationcancel event, treat the CSS Animation(s) for which the animationcancel event was generated as having an owning element corresponding to the owning element in use at the moment when the CSS Animation was cancelled. Furthermore, use the position of the animation in the animation-name property in effect at the time when the CSS Animation was cancelled sorting such that positions of cancelled animations sort before positions of animations that have not been cancelled.

Comment 1

[Boris Chiou [:boris]]

Attachment: Bug 1933281 - Fallback to compare the order of event targets for CSSAnimation if they have the same time.

Just like what we do for CSSTransition, we use the similar way to handle
CSSAnimation with the same schedule time.

Comment 2

[Boris Chiou [:boris]]

try: https://treeherder.mozilla.org/jobs?repo=try&revision=6a107f90357e7448206d97e5dff58633a0ee1cf5

Comment 3

[Boris Chiou [:boris]]

Attachment: Bug 1933281 - Add more wpt for events sorting.

Add some tests for animation events sorting, per the spec issue:
https://github.com/w3c/csswg-drafts/issues/11064#issuecomment-2445782077,
and follow the spec:
https://drafts.csswg.org/css-animations-2/#animation-composite-order

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/495c6765094e
Add more wpt for events sorting. r=hiro

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/49434 for changes under testing/web-platform/tests

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/495c6765094e

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 8

[BugBot [:suhaib / :marco]]

The leave-open keyword is there and there is no activity for 6 months.
:boris, maybe it's time to close this bug?
For more information, please visit BugBot documentation.

Comment 9

[Boris Chiou [:boris]]

No need this keyword, and I have to try to push the 2nd patch again.