Closed Bug 1933293 Opened 2 months ago Closed 29 days ago

Rework aboutWelcome modal behavior to still show about:welcome page and make requiring action to proceed configurable

Categories

(Firefox :: Messaging System, enhancement, P1)

Product:
Firefox
Component:
Messaging System
Type:
enhancement
Points:
2

Tracking

()

Status:
RESOLVED FIXED
Milestone:
135 Branch
Iteration:
135.2 - Dec 9 - Dec 20
Tracking Flags:
Tracking Status
firefox135 --- fixed

People

(Reporter: mviar, Assigned: mviar)

References

(
URL
)

Details

Attachments

(1 file)

Bug 1933293 - Rework aboutWelcome modal behavior to still show about:welcome page and make requiring action to proceed configurable
48 bytes, text/x-phabricator-request
Details | Review

When the aboutWelcome Nimbus feature's showModal variable is enabled, don't skip showing the main about:welcome page and make requiring action to proceed configurable (this includes setting the message's modal content attribute to "window" and disableEscClose to true.
See here in BrowserContentHandler.

Summary: Rework aboutWelcome modal behavior to still show about:welcome page → Rework aboutWelcome modal behavior to still show about:welcome page and accept additional content attributes
Depends on: 1933221
Summary: Rework aboutWelcome modal behavior to still show about:welcome page and accept additional content attributes → Rework aboutWelcome modal behavior to still show about:welcome page and accept disableEscClose as a content attribute
Assignee: nobody → mviar
Iteration: --- → 135.1 - Nov 25 - Dec 6
Priority: -- → P1
Summary: Rework aboutWelcome modal behavior to still show about:welcome page and accept disableEscClose as a content attribute → Rework aboutWelcome modal behavior to still show about:welcome page and make requiring action to proceed configurable
Attachment #9439836 - Attachment description: WIP: Bug 1933293 - Rework aboutWelcome modal behavior to still show about:welcome page and accept disableEscClose as a content attribute → WIP: Bug 1933293 - Rework aboutWelcome modal behavior to still show about:welcome page and make requiring action to proceed configurable
Attachment #9439836 - Attachment description: WIP: Bug 1933293 - Rework aboutWelcome modal behavior to still show about:welcome page and make requiring action to proceed configurable → Bug 1933293 - Rework aboutWelcome modal behavior to still show about:welcome page and make requiring action to proceed configurable
Iteration: 135.1 - Nov 25 - Dec 6 → 135.2 - Dec 9 - Dec 20
Pushed by mviar@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c57aae160172 Rework aboutWelcome modal behavior to still show about:welcome page and make requiring action to proceed configurable r=firefox-desktop-core-reviewers ,mossop,pdahiya

https://hg.mozilla.org/mozilla-central/rev/c57aae160172

Status: NEW → RESOLVED
Closed: 29 days ago
status-firefox135: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 135 Branch
Flags: qe-verify+
Depends on: 1940580
No longer depends on: 1940580
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: