1933342 - Move getCommonPfx helper to handlers.js in cZ

Status: RESOLVED FIXED

(SeaMonkey :: Chat, task)

Description

[Ian Neal]

The only caller for the helper getCommonPfx is in the function onTabCompleteRequest in handlers.js, so let's move the helper into that function.

Comment 1

[Ian Neal]

Attachment: 1933342-irc-handlers-getCommonPfx-25320.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.20pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9439841 [details] [diff] [review]
1933342-irc-handlers-getCommonPfx-25320.patch

lgtm r/a+

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d07aabe47e8f
Move getCommonPfx helper to handlers.js in cZ. r=frg

Comment 4

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/b09c692fc08836ddb9b38ebd330286b1350e9825
Move getCommonPfx helper to handlers.js in cZ. r=frg a=frg