1933346 - Remove some code duplication in getSISize and getSISpeed helpers and improve coding in scaleNumbersBy1024 in cZ

Status: RESOLVED FIXED

(SeaMonkey :: Chat, enhancement)

Description

[Ian Neal]

There's a fair amount of duplicated code between getSISize and getSISpeed helpers, also the code in scaleNumberBy1024 could be recoded to make use of new Math methods.

Comment 1

[Ian Neal]

Attachment: 1933346-irc-utils-scale-25320.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.20pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9439844 [details] [diff] [review]
1933346-irc-utils-scale-25320.patch

lgtm r/a+

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b050791cbc90
Remove some code duplication in getSISize and getSISpeed helpers and improve coding in scaleNumbersBy1024 in cZ. r=frg

Comment 4

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/3c8bcccbbbb8c41813b450fe0e15d443308ce775
Remove some code duplication in getSISize and getSISpeed helpers and improve coding in scaleNumbersBy1024 in cZ. r=frg a=frg