1933416 - The profile name, "Back" and "Edit" icons are not visible in the Hamburger Menu

Status: RESOLVED DUPLICATE of bug 1950167

(Toolkit :: Startup and Profile System, defect, P2)

Description

[Raluca Popovici, Desktop QA]

Attachment: image_2024_11_26T09_45_34_335Z (1).png

Found in:
Nightly 134.0a1

Affected versions:
Nightly 134.0a1

Tested platforms:
Affected platforms: macOS 13.2.1, Windows 10

Preconditions:
Ensure that the pref "browser.profiles.enabled" is set to true in about:config and the system theme is set to Dark.

Steps to reproduce:

1. Open the Profiles panel from the menu bar.
2. Using the "New profile" option, create a profile with the system theme selected by default.
3. Change the system theme to "Light".
4. Go to the Hamburger menu, click on [profile name], and observe the upper side of the profiles submenu.

Expected result:
The profile name, "Back" and "Edit" icons should be visible in the profiles submenu.

Actual result:
The profile name, "Back" and "Edit" icons are not visible. Please see the screenshot.

Regression range:
This is not a regression.

Comment 1

[Niklas Baumgardner [:niklas]]

Hi Raluca, can you still reproduce this bug? Bug 1927572 recently changed the theme observer code and I'm not able to reproduce this issue anymore.
Thanks!

Comment 2

[Raluca Popovici, Desktop QA]

The buttons and profile name are still difficult to see. Please see the screenshot(profilename.png)

Preconditions:
Ensure that the pref "browser.profiles.enabled" is set to true in about:config and the system theme(OS settings) is set to Dark.

Steps to reproduce:

1. Open the Profiles panel from the menu bar.
2. Using the "New profile" option, create a profile with the system theme selected by default.
3. Change the system theme(OS Settings) to "Light".
4. Go to the Hamburger menu, click on [profile name], and observe the upper side of the profiles submenu.

Comment 3

[Raluca Popovici, Desktop QA]

Attachment: profilename.png

Comment 4

[Niklas Baumgardner [:niklas]]

I can't reproduce with these steps. We also recently landed bug 1927567, which selects a random theme when a profile is started for the first time. So maybe that bug resolves the issue?

Comment 5

[Raluca Popovici, Desktop QA]

Could you please follow the exact steps shown in the video from the provided link? I hope this is more helpful.
https://drive.google.com/file/d/1GRjxvyoHgnIfywV4Px1gR9-Lh9F6qLzS/view?usp=drive_link

Comment 6

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Mass setting S2 severity for 0.5% release bugs. Apologies for the bug spam!

Comment 7

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

I can confirm this issue is still reproducible when the user creates a profile, selects the system theme, switches their OS from dark to light, then opens the profiles panel in the hamburger menu.

Comment 8

[Rebecca]

May be a dupe of 1927193

Comment 9

[Niklas Baumgardner [:niklas]]

I think this is fixed by bug 1927193.
Raluca, can you still reproduce?

Comment 10

[Raluca Popovici, Desktop QA]

Attachment: Screenshot 2025-02-26 at 18.16.26.png

Comment 11

[Raluca Popovici, Desktop QA]

This issue is not fixed by bug 1927193. I can reproduce it with the steps from the description on MacOS 13.2.1 using the latest Nightly 137.0a1 from 26-feb-2025. I will attach my result.

Comment 12

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Edited again - I can still reproduce this bug if I set the theme to light, then set the theme to system, then switch my macOS from light to dark mode.

I do suspect it's related to bug 1950167 after all.

Comment 13

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

I think this will likely turn out to be a duplicate of either bug 1950167 or bug 1953316.

Comment 14

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: screenshot - fixed.png

Looks like this was fixed by bug 1950167. See screenshot--now when the system theme is randomly selected, the profiles submenu buttons look correct after switching to the light profile.

Comment 15

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Marking as a dupe of 1950167. Please reopen if you can still reproduce the bug, thanks!

Comment 16

[Raluca Popovici, Desktop QA]

I can't reproduce this issue on Nightly 139.0a1 and Betab 138.0b1 using the steps from the description. I will clear the needinfo.