1933466 - Remove the empty box-shadow around focused tab

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P3)

Description

[Julian Descottes [:jdescottes]]

STRs:

• open DevTools
• open Inspector
• select the "Computed" sidebar tab
• make sure the tab is focused (ie the focus ring is displayed)

Issue: there is a small blank/white padding surrounding the tab.

The box shadow forced at https://searchfox.org/mozilla-central/rev/dfaf02d68a7cb018b6cad7e189f450352e2cde04/devtools/client/themes/common.css#304-307

:focus-visible {
  outline: var(--theme-focus-outline);
  outline-offset: var(--theme-outline-offset);
  box-shadow: var(--theme-outline-box-shadow);

partially hides the tabs which are sitting next to the selected tab of a devtools tabbar. We should override it for the Tabbar specifically because we know that in this case the focus ring should always be visible.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1933466 - [devtools] Remove the empty box-shadow around focused tab

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79d6a5490161
[devtools] Remove the empty box-shadow around focused tab r=nchevobbe,devtools-reviewers

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/79d6a5490161