1933485 - Deleted tab groups sometimes do not appear in the history menus

Status: RESOLVED FIXED

(Firefox :: Session Restore, task, P1)

Description

[Jeremy Swinarton (PTO 2025-11-21 to 2025-11-28)]

I have noticed that since the landing of bug1927774, deleted tab groups do not always appear in the history context menus.

I am not sure exactly what's causing this but I suspect there may be a race condition related to the event that passes the group data to session store. It could be that by the time the event makes it to session restore, the tabs have already been removed, and thus session restore interprets this as an empty group and ignores it.

Comment 1

[Stephen Thompson [:sthompson]]

:jswinarton I saw this in my manual testing. I saw this most frequently if I created a new tab group and then deleted it very soon after creation. I do not think I saw this issue happen when deleting a tab group that had been around for a minute or more.

The onTabGroupRemoveRequested handler operates on the state of immediate state of the session.

A lot of the session state operations occur after a delay; it may be that we need to do something like SessionStoreInternal.onMoveToNewWindow where we flush the state first.

Comment 2

[Jeremy Swinarton (PTO 2025-11-21 to 2025-11-28)]

Attachment: Bug 1933485: Ensure tab groups always appear in history menus r?dao,dwalker,sthompson

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc54aa089022
Ensure tab groups always appear in history menus r=dao,sthompson,sessionstore-reviewers

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/bc54aa089022