1933488 - When closing the toolbar while scrolling Google SERP, an empty space with a black background appears

Status: VERIFIED FIXED

(GeckoView :: General, defect)

Description

[eclaudiu64]

Attachment: mobizen_20241126_170051.mp4

User Agent: Mozilla/5.0 (Android 10; Mobile; rv:135.0) Gecko/135.0 Firefox/135.0

Steps to reproduce:

When closing the toolbar while scrolling, an empty space with a black background appears white collar background appears at the bottom and top covering the screen

Actual results:

Empty space appears when closing the toolbar and when scrolling through the site

Expected results:

Covered space not to appear

Comment 1

[eclaudiu64]

It can be verified, I see that this bug is progressing to the official version

Comment 2

[Chris Peterson [:cpeterson]]

Is this a bug in Fx 133 or 134? Fx 133 is going to the Release channel this week and 134 is going to the Beta channel this week.

Comment 3

[Chris Peterson [:cpeterson]]

I can reproduce this bug in Nightly 135 using the old toolbar. I can reproduce when scrolling the Google search results page, but not other sites like Wikipedia. I can't reproduce when using the new toolbar.

I can't reproduce in Fx 133. I can't test Beta 134 because it hasn't be published to the Play Store yet.

Comment 4

[eclaudiu64]

I can reproduce in 135 Nightly and 134 Beta downloaded from FTP Fenix, probably also in 133 version officially. I can reproduce on all sites with both the old bar and the new bar.

Comment 5

[Chris Peterson [:cpeterson]]

I can't reproduce in Fx 133 or Beta 133.0b9. If you can reproduce in 133, then maybe Google is experimenting with multiple versions of the search results page design?

I can reproduce in Nightly 135 using the old toolbar, but not the new toolbar.

Comment 6

[Petru-Mugurel Lingurar [:petru]]

Attachment: NoIssue.mp4

I can't reproduce this on the latest Nightly or on 134b1.

@eclaudiu64 Do you have any secret settings or addons enabled?
Can you post the full URL of the google search? - If looking at the top of the page I have the Google header image plus a profile button but you do not <=> we see different search pages.

Comment 7

[Petru-Mugurel Lingurar [:petru]]

Also asking QA for help in understanding the conditions for reproducing this.

Comment 8

[Petru-Mugurel Lingurar [:petru]]

Attachment: NoIssue2.mp4

Tested more, added another video where I still can't reproduce although I'm being closer to reporter's video - getting results in romanian and the url bar showing the full url instead of just the search term.

Comment 9

[eclaudiu64]

I have nothing added, the profile is new, new installation. The first time does not reproduce, but if You have to browse more sites in the same session per tab and open other tabs and scroll each time. Also try to put the android buttons on the original ones and try again.

Comment 10

[Petru-Mugurel Lingurar [:petru]]

I still can't reproduce (on different devices and emulators)
But thinking about what could cause this and seeing at the beginning of eclaudiu64's recording that the "blank space" moves or changes it's height and then also that it has a different colour than the toolbar it seems to me like this is not caused by the the app but it's either

• unrendered space by GeckoView or
• rendered as requested by the webpage

Comment 11

[eclaudiu64]

I think I found a way to reproduce the error: we give the first video in my screenshot and press the fullscreen button and then press the fullscreen button again to exit. Can you try ?

Comment 12

[Petru-Mugurel Lingurar [:petru]]

Attachment: NoIssue3.mp4

(In reply to eclaudiu64 from comment #11)

I think I found a way to reproduce the error: we give the first video in my screenshot and press the fullscreen button and then press the fullscreen button again to exit. Can you try ?

Thank you for this!
Still can't reproduce unfortunately but asked others to help.
The issue might be device specific, can you share the device & Android version that you're seeing this on?

Comment 13

[eclaudiu64]

I can reproduce the error on Samsung Galaxy and Moto G85, Android 11 and Android 13. It doesn't seem to be specific to certain phone models. This error must be reproduced somehow.

Comment 14

[eclaudiu64]

I hope it doesn't make it to the official version, it's already made it to the Beta version.

Comment 15

[Delia Pop (Android QA)]

Attachment: OPPO_A15.mp4

I was able to reproduce this issue on Nightly 135.0a1 from 11/28 (with old toolbar enabled) and Beta 134.0b2 on a single device, OPPO A15s (Android 10).
This issue appears to be intermittent: it could be reproduced mostly after performing another search and scrolling through the results, or after changing the toolbar position/theme in Settings, then returning to the search results page and continue scrolling.

Additionally, after some scrolling/searches, I noticed a smaller empty space being displayed above the nav bar and under the address bar (when set to top), depending on the scrolling position.

Comment 16

[Delia Pop (Android QA)]

Attachment: smaller_space.jpg

Comment 17

[Petru-Mugurel Lingurar [:petru]]

Attachment: image.png

With great help from Delia (many thanks!) we found out the exact culprit - the patches that enable edge-to-edge support in Fenix - bug 1911042.
Doesn't seem like these themselves cause the issue but rather surface an issue in GeckoView which doesn't fully adapt to the new display viewport and sometimes the rendering remains incomplete.

Pending more investigation we should disable that functionality which in light testing by Delia (many thanks!) showed the issue disappearing.

Comment 18

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1933488 - Stop manually handling window insets r=#android-reviewers

We'll rely on opting out of edge-to-edge support in the application while
investigating more the effects of us manually handling window insets.

Comment 19

[Chris Peterson [:cpeterson]]

Setting status-firefox133 = affected since bug 1911042 shipped in Fx 133.

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad0edb519cfd
Stop manually handling window insets r=android-reviewers,tchoh

Comment 21

[Petru-Mugurel Lingurar [:petru]]

Attachment: ContentClippedWhenOverscrolled.mp4

New recording which offers some details into what might be happening.
Seems like rendered content is clipped "permanently" when scrolled offscreen.
An important other detail is that this does not happen with a fixed toolbar.

Comment 22

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/ad0edb519cfd

Comment 23

[Petru-Mugurel Lingurar [:petru]]

@ QA Please check to ensure that the issue disappearance and there are no other issues with blank space / content padding even on other devices and Android versions >Android 10.

Comment 24

[Pascal Chevrel:pascalc]

Petru, is that something we should uplift to 134? Thanks

Comment 25

[Petru-Mugurel Lingurar [:petru]]

(In reply to Pascal Chevrel:pascalc from comment #24)

Petru, is that something we should uplift to 134? Thanks

Thanks for the ping!
Indeed, we'd probably want this in beta also.
Was just waiting for a confirmation from QA that everything looks good after the change.
Keeping my NI until then.

Comment 26

[Delia Pop (Android QA)]

I can no longer reproduce this issue in the latest Nightly 135.0a1 from 12/10 with OPPO A15s (Android 10).
I’ve also tested with Google Pixel 8 Pro (Android 14), Lenovo Yoga Tab 11 (Android 12) and LG G7 fit (Android 9), with the new and old toolbar and no other issues were observed.
I'll leave the "qe-verify+" flag until this can also be verified in Beta.

Comment 27

[Petru-Mugurel Lingurar [:petru]]

Comment on attachment 9440552 [details]
Bug 1933488 - Stop manually handling window insets r=#android-reviewers

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: On certain devices we observed padding issues for snackbars or even GeckoView rendering in a smaller viewport padded with blank space.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Use the steps from bug 1933488 and bug 1932904 to validate
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small targeted change validated by QA in Nightly.
• String changes made/needed:
• Is Android affected?: Yes

Comment 28

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/b6331a3c6564

Comment 29

[Delia Pop (Android QA)]

Verified as fixed on Beta 134.0b10 as well with the following devices:
OPPO A15s (Android 10)
Pixel 9 Pro XL (Android 15)
OnePlus 12R (Android 14)
Sony Xperia z5 Premium (Android 7.1.1)
Samsung S24 Ultra (Android 14)

Comment 30

[Petru-Mugurel Lingurar [:petru]]

Investigating what on GeckoView's side might contribute to the issue I think it's the new "interactive resize" feature from bug 1831649.
Testing on https://www.wikipedia.org I see that after disabling dom.interactive_widget_default_resizes_visual the issue does not reproduce anymore.

Comment 31

[Petru-Mugurel Lingurar [:petru]]

(In reply to Chris Peterson [:cpeterson] from comment #3)

I can reproduce this bug in Nightly 135 using the old toolbar. I can reproduce when scrolling the Google search results page, but not other sites like Wikipedia. I can't reproduce when using the new toolbar.

I can't reproduce in Fx 133. I can't test Beta 134 because it hasn't be published to the Play Store yet.

May I ask on which device/Android version were you able to reproduce this?

Comment 32

[Chris Peterson [:cpeterson]]

May I ask on which device/Android version were you able to reproduce this?

I can no longer reproduce this bug because the fix has landed, but I'm pretty sure I reproduced this bug on both my Samsung Galaxy A32 and Moto G5.

Comment 33

[Petru-Mugurel Lingurar [:petru]]

Thanks, I think both of these are on Android 13 which shows a wider range of Android versions possibly affected.

Comment 34

[eclaudiu64]

I have also noticed that I can reproduce this error, it happens less often, but it does happen.

Comment 35

[Petru-Mugurel Lingurar [:petru]]

(In reply to eclaudiu64 from comment #34)

I have also noticed that I can reproduce this error, it happens less often, but it does happen.

Thanks for the report!
This still happening increases the likelihood that this is an issue about how we compute the layouts for web content, similar to other issues like bug 1938303 or bug 1937785.

Comment 36

[Petru-Mugurel Lingurar [:petru]]

Attachment: WIP: Bug 1933488 - Use manual handling of window insets

This is a workaround to Android 15's edge-to-edge behavior while allowing for
synchronizing UI elements animations with the virtual keyboard showing up or
being hidden.

Comment 37

[BugBot [:suhaib / :marco/ :calixte]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Comment 38

[Donal Meehan [:dmeehan]]

:petru, adding a NI about comment 37. For tracking purposes please use a different bug for your patch.

Comment 39

[Petru-Mugurel Lingurar [:petru]]

(In reply to Donal Meehan [:dmeehan] from comment #38)

:petru, adding a NI about comment 37. For tracking purposes please use a different bug for your patch.

I will do that, thank you!
Though about this impacting tracking after I pushed the PR :-(.