1933552 - Log spam: java.lang.SecurityException: Package org.mozilla.geckoview.test_runner has not requested permission android.permission.READ_EXTERNAL_STORAGE

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

Same as in bug 1777710 previously, now the READ_EXTERNAL_STORAGE permission is deprecated for Android 33+. We should apply the same fix that was done for the WRITE permission before to cut down on the noise in the logs.

INFO -  Granting important runtime permissions to org.mozilla.geckoview.test_runner
INFO -  Unable to grant runtime permission android.permission.READ_EXTERNAL_STORAGE to org.mozilla.geckoview.test_runner due to args: adb wait-for-device shell su -c 'pm grant org.mozilla.geckoview.test_runner android.permission.READ_EXTERNAL_STORAGE', exitcode: 255, stdout:
INFO -  Exception occurred while executing 'grant':
INFO -  java.lang.SecurityException: Package org.mozilla.geckoview.test_runner has not requested permission android.permission.READ_EXTERNAL_STORAGE
INFO -  	at com.android.server.pm.permission.PermissionManagerServiceImpl.grantRuntimePermissionInternal(PermissionManagerServiceImpl.java:1404)
INFO -  	at com.android.server.pm.permission.PermissionManagerServiceImpl.grantRuntimePermission(PermissionManagerServiceImpl.java:1319)
INFO -  	at com.android.server.pm.permission.PermissionManagerService.grantRuntimePermission(PermissionManagerService.java:547)
INFO -  	at android.permission.PermissionManager.grantRuntimePermission(PermissionManager.java:597)
INFO -  	at com.android.server.pm.PackageManagerShellCommand.runGrantRevokePermission(PackageManagerShellCommand.java:2546)
INFO -  	at com.android.server.pm.PackageManagerShellCommand.onCommand(PackageManagerShellCommand.java:292)
INFO -  	at com.android.modules.utils.BasicShellCommandHandler.exec(BasicShellCommandHandler.java:97)
INFO -  	at android.os.ShellCommand.exec(ShellCommand.java:38)
INFO -  	at com.android.server.pm.PackageManagerService$IPackageManagerImpl.onShellCommand(PackageManagerService.java:5954)
INFO -  	at android.os.Binder.shellCommand(Binder.java:1049)
INFO -  	at android.os.Binder.onTransact(Binder.java:877)
INFO -  	at android.content.pm.IPackageManager$Stub.onTransact(IPackageManager.java:4313)
INFO -  	at com.android.server.pm.PackageManagerService$IPackageManagerImpl.onTransact(PackageManagerService.java:5938)
INFO -  	at android.os.Binder.execTransactInternal(Binder.java:1285)
INFO -  	at android.os.Binder.execTransact(Binder.java:1244)

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1933552 - Don't request READ_EXTERNAL_STORAGE permission on Android 13+.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/99cf99938715
Don't request READ_EXTERNAL_STORAGE permission on Android 13+. r=jmaher,sparky

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/99cf99938715

Comment 4

[Intermittent Failures Robot]

16 failures in 3953 pushes (0.004 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 11
• autoland: 5

Platform and build breakdown:

• android-hw-p5-13-0-android-aarch64-qr: 7
  • debug: 6
  • opt: 1
• android-hw-p5-13-0-android-aarch64-shippable-qr: 2
  • opt: 2
• android-hw-a55-14-0-aarch64-shippable: 7
  • opt: 7

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1933552&startday=2024-11-25&endday=2024-12-01&tree=all