Closed Bug 1933608 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 49384 - [shared storage] Implement `withLock` option for methods from PA worklets

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox135 fixed)

RESOLVED FIXED
135 Branch
Tracking Status
firefox135 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Attachments

(1 file)

Sync web-platform-tests PR 49384 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/49384
Details from upstream follow.

Yao Xiao <yaoxia@chromium.org> wrote:

[shared storage] Implement withLock option for methods from PA worklets

Similar to what has been done for Window, SharedStorageWorklet, and
response headers, we add the withLock parameter parsing logic in the
PA worklet, and send the final request to the browser process's central
SharedStorageLockManager component.

We reuse AccessType::kWorkletSet, etc. for displaying events in
DevTools. Filed crbug.com/380291909 to further distinguish PA
worklet access from shared storage worklet access.

Bug: 373899210
Change-Id: Ia16d256167be5a43adba699c2c9b55a626f7b0e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6047561
Reviewed-by: Maks Orlovich \<morlovich@chromium.org>
Commit-Queue: Yao Xiao \<yaoxia@chromium.org>
Reviewed-by: Cammie Smith Barnes \<cammie@chromium.org>
Reviewed-by: Ken Buchanan \<kenrb@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1388539}

Attached file Notable wpt changes
# CI Results Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 185 tests and 3 subtests ## Status Summary ### Firefox `OK` : 184 `FAIL` : 872 `ERROR` : 1 `NOTRUN` : 1 ### Chrome `OK` : 181 `PASS` : 221 `FAIL` : 633 `TIMEOUT`: 8 `NOTRUN` : 15 ### Safari `OK` : 184 `FAIL` : 872 `ERROR` : 1 `NOTRUN` : 1 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=7d66e0bff438f6e0328fe7f68dde3598fde538ed) [GitHub PR Head](https://wpt.fyi/results/?sha=eebaf38c93a4c6a89d1bf2fd5cf6c0910ffa2d57&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=eebaf38c93a4c6a89d1bf2fd5cf6c0910ffa2d57&label=pr_base) ## Details (See attachment for full changes)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/42dfcdb0b95d [wpt PR 49384] - [shared storage] Implement `withLock` option for methods from PA worklets, a=testonly
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 135 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: