1933652 - [toolbar redesign] Allow the redesign toolbar be enabled in beta+

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, task)

Description

[Petru-Mugurel Lingurar [:petru]]

Currently the redesigned toolbar is blocked to just debug & nightly with a feature flag.

To allow the feature be enabled on beta+ we should remove the feature flag, similar to how we treat the redesigned menu feature after which it will be possible to update it's availability through Nimbus (currently the feature is disabled by default on beta+).

Note the the secret setting to allow users enable or disable this would still remain blocked to only debug & nightly.

Comment 1

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1933652 - Allow the redesigned toolbar be enabled in beta+ releases r=#android-reviewers

This does not enable the feature on beta+ but allows it to be enabled through Nimbus.
The feature is currently enabled by default on debug & nightly and disabled by default
on beta & release.

Comment 2

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1933652 - Remove the `navigationToolbarEnabled` feature flag r=#android-reviewers

It was only used in debug tools where checking whether the redesigned toolbar is shown
or not is more reliable guard.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f91bd7ffb96d
Allow the redesigned toolbar be enabled in beta+ releases r=android-reviewers,skhan

Comment 4

[Petru-Mugurel Lingurar [:petru]]

Comment on attachment 9440156 [details]
Bug 1933652 - Allow the redesigned toolbar be enabled in beta+ releases r=#android-reviewers

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: After checking with product we want to be able to enable the redesigned toolbar through Nimbus in the current Beta release - 134.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): We simply remove a flag blocking a feature to just debug and Nightly irrespective of Nimbus configuration.
  After this the redesigned toolbar feature can be enabled through Nimbus on beta+.
• String changes made/needed:
• Is Android affected?: Yes

Comment 5

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/f91bd7ffb96d

Comment 6

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/125d9ba31538

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c8030104667
Remove the `navigationToolbarEnabled` feature flag r=android-reviewers,npoon

Comment 8

[amarc]

https://hg.mozilla.org/mozilla-central/rev/7c8030104667