1933680 - Reset root directory should always be visible when a directory root is set

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Julian Descottes [:jdescottes]]

We should probably scope the directory root feature per domain/url, but in the meantime we should already make sure the button to clear the setting is always visible when a directory root is set.

Note: the icon is not very explicit, might be good to improve this here or in follow up.

Comment 1

[Holger Benl [:hbenl]]

Attachment: Bug 1933680 - [devtools] Always show the directory root header when a directory root is set. r=#devtools-reviewers,ochameau

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/911f9b17aadf
[devtools] Always show the directory root header when a directory root is set. r=ochameau,devtools-reviewers

Comment 3

[Norisz Fay [:noriszfay]]

Backed out for causing dt failures on browser_dbg-project-root.js, browser_parsable_css.js

Backout link

Push with failures

Failure log / Failure log 2

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b1fc49694cd4
[devtools] Always show the directory root header when a directory root is set. r=ochameau,devtools-reviewers

Comment 5

[Atila Butkovits]

Backed out for causing failures at browser_dbg-quick-open.js.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/0963e7a5fc887251dc9a434f22f1ab7ab08f5517

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=7451144df2ea01c0fdcf515dd4e2dd1c660a871a&selectedTaskRun=Dzgrz3MqQzCJuk8IFrCvhQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=504073961&repo=autoland&lineNumber=6847

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/530efd7cc243
[devtools] Always show the directory root header when a directory root is set. r=ochameau,devtools-reviewers

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/530efd7cc243