1933695 - Clean up command and menuitem handling for UndoCloseTab

Status: NEW

(Firefox :: Session Restore, enhancement)

Description

[Simon Friedberger [:simonf]]

I've fixed some bugs in the code in bug 1932640.

After a lot of discussion with :dao it seems the high-level issue was that we are setting the disabled state on the <command> but we are setting the l10n attributes on the individual menuitems and not everything was always properly synchronized.

It should now be correct in all relevant places, however, the code is setting the disabled state on the command when the menus which have access to it are opened meaning the state may become incorrect while the items are not visible. This may cause issues with keyboard shortcuts or when somebody uses the command in new ways.

Comment 1

[Marco Bonardo [:mak]]

While this is probably part of the History menu, it's more of a Session Restore bug, I think.