1933696 - genius.com - Unable to fully type when suggestions are still loading

Status: VERIFIED FIXED

(GeckoView :: IME, defect, P2)

Description

[Raul Bucata]

Environment:
Operating system: Android
Firefox version: Firefox 110.0

Steps to reproduce:

1. Navigate to: https://genius.com/
2. Tap on the search bar
3. Once prompted, type a sentence and observe

Expected Behavior:
Typing works correctly

Actual Behavior:
Typing shows issues if the suggestions are not loaded completely

Notes:

• Reproduces regardless of the status of ETP
• Reproduces in firefox-nightly, and firefox-release
• Does not reproduce in chrome

Created from https://github.com/webcompat/web-bugs/issues/119275

Comment 1

[Raul Bucata]

Attachment: Chr vs FF

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 3

[Sean Feng [:sefeng211]]

I chased this all the way up to here https://searchfox.org/mozilla-central/rev/d4235354139ae0da3b15b89943b140b510a74f2f/widget/android/GeckoEditableSupport.h#149 and noticed we missed some ::OnNativeCall, so we missed some characters when typing. Then this seems to relate to how native events are dispatched on Android?

Masayuki, do you have ideas about this? I could ask the android folks to take a look if this is not something for DOM.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Android specific IME part is maintained by Makoto-san. Makoto-san, do you have any ideas?

Comment 5

[Makoto Kato [:m_kato]]

As long as I looking video, text selection is updated incorrectly. But I cannot reproduce this... I have to find reproducing way.

Comment 6

[Sean Feng [:sefeng211]]

Thanks for looking this Makoto-san.

I can reproduce this quite easily, just typing fast. For example, if I type helo, the last o often got eaten by something...Let me know if you want me to generate something for you.

For the purpose of triaging this, given I don't see evidences that the site does something wrong, so I'll label this as a platform bug for now.

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I can reproduce this with either ATOK Pro or Gboard.

When I type text with ATOK Pro, the composition string was forcibly committed when (?) the throbber appears. Could be caused by focus handling?

Comment 8

[Sean Feng [:sefeng211]]

Geckoview::IME seesm to be a good component for start.

Comment 9

[Makoto Kato [:m_kato]]

This will be fixed by bug 1995911. Content has a lot of child documents, so GeckoEditable tries to reset keyboard from GeckoEditableSupport::TransferParent per finishing to create a child document.

Comment 11

[Jeff Muizelaar [:jrmuizel]]

REOPENING because we're generally keeping site issue bugs separate for each site and not duping them. I've added a dependency instead.

Comment 12

[Jeff Muizelaar [:jrmuizel]]

We can close it as fixed when the problem is confirmed fixed on nightly

Comment 13

[Makoto Kato [:m_kato]]

After landing bug 1995911, composing text isn't committed during inputting a text. (Before that such as Firefox beta, when starting search, text is often committed)

Comment 14

[Raul Bucata]

Verified as FIXED using RC Build fenix android-arm64-v8a

Tested with:

Browser / Version: Firefox 146.0 Build 2016129538
Operating System: Google Pixel 3 (Android 12) -1080 x 2160 pixels, 18:9 ratio (~443 ppi density)
Operating System: Oppo Find X5 (Android 13) - 1080 x 2400 pixels, 20:9 ratio (~402 ppi density)

Comment 15

[Ryan VanderMeulen [:RyanVM]]

I'm a bit confused - bug 1995911 landed in 147 but this was verified as fixed in 146?

Comment 16

[Raul Bucata]

This bug had no milestone set, so when we are doing a re-verification with the RC Build, if it has the current version fixed (146 in our case) we are acting accordingly.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

Right, but my point is that if bug 1995911 is what was expected to fix this, 146 should still reproduce. Working correctly on 146 isn't the expected result.

Comment 18

[Raul Bucata]

Correct, I can still see a delay in 146 RC Build. I've missed that, sorry about the confusion

Comment 19

[Raul Bucata]

I've re-edited the report and added the 147 milestone. Please feel free to modify as you see fit, if it is not correct.

Comment 20

[Ryan VanderMeulen [:RyanVM]]

Sounds like the bug should be reopened then unless it's been verified on a Nightly 147 build...

Comment 21

[Jeff Muizelaar [:jrmuizel]]

Raul, can you confirm it's been fixed in 147?

Comment 22

[Raul Bucata]

The latest Beta for Firefox Android works as expected, version 147b2. When typing, the caret does not jump, and words are typed correctly while suggestions are loading

Comment 23

[Raul Bucata]

Attachment: firefox beta 147 fixed.mp4

Comment 24

[Calin Tanase]

Verified, the issue no longer reproduces.

Tested with:

• Browser / Version: Fenix 147.0-candidate build 1
• Operating System: Google Pixel 5 (Android 14)