1933758 - The profiles list in the "Profile Selector" window shows a vertical and horizontal scroll bar when there is no overflow

Status: VERIFIED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Raluca Popovici, Desktop QA]

Attachment: Screenshot 2024-11-27 at 17.58.11.png

Found in:
Nightly 134.0a1

Affected versions:
Nightly 134.0a1

Tested platforms:
Affected platforms: Windows 10

Preconditions:
Ensure that the pref "browser.profiles.enabled" is set to true in about:config.
Create at least 2 switching profiles.

Steps to reproduce:

1. Open the "Profiles" from the menu bar.
2. Click on the "Manage profiles" option
3. Observe the overflow scroll bar

Expected result:
Based on the Figma specs, the overflow scroll bar should only be displayed when there are more profiles than can be shown in the current view. This also applies when resizing the browser.

Actual result:
The profiles list in the "Profile Selector" window shows a vertical and horizontal scroll bar when there is no overflow. Please see the screenshot.

Regression range:
This is not a regression.

Comment 1

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Does this only occur when scrollbars are set to always show?

Comment 2

[Raluca Popovici, Desktop QA]

The issue persists(on Windows 10 only) whether "Automatically hide scroll bars in Windows"(OS Settings) is enabled or disabled.

Comment 3

[Tom Schuster (MoCo) | OOO back 1. Dec]

Attachment: "Chooser User Profile" Screenshot

I think I have a similar issue on Linux Mint.

Comment 4

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

please ignore - needinfoing myself as a test of the BMO notification system

Comment 5

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Updating the bug title - this issue occurs across platforms if the user has set scrollbars to always be visible:

• Windows 11: Windows Settings > Accessibility > Visual effects > Always show scrollbars
• MacOS: System Settings > Appearance > Show scroll bars set to 'Always'

Comment 6

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Bug 1933758 - Hide scrollbars in the profile selector dialog unless content overflows. r?#profiles-reviewers

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d3d6f6e9cf79
Hide scrollbars in the profile selector dialog unless content overflows. r=profiles-reviewers,desktop-theme-reviewers,emilio,mossop

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/d3d6f6e9cf79

Comment 9

[Raluca Popovici, Desktop QA]

Verified as fixed on Windows 10 and MacOS 13.2.1 using Nightly treeherder build and the latest Nightly.