1933803 - Remove explicitly stored per-span data from nsGridContainerFrame::Tracks::ResolveIntrinsicSize

Status: RESOLVED FIXED

(Core :: Layout: Grid, enhancement, P5)

Description

[Emily McDonough [:alaskanemily]]

Whether or not this is actually useful to store separately is debatable. While we will need to iterate spans to recalculate this in step 3, we already need to iterate the tracks multiple times for step 3 so this doesn't affect the complexity of the operation and this iteration is cheap.

Comment 1

[Emily McDonough [:alaskanemily]]

Attachment: Bug 1933803 - Remove explicitly stored per-span data from nsGridContainerFrame::Tracks::ResolveIntrinsicSize

Whether not this is actually useful to store separately is debatable.
While we will need to iterate spans to recalculate this in step 3, we
already need to iterate the tracks multiple times for step 3 so this
doesn't affect the complexity of the operation and this iteration is
relatively cheap.

This data was stored in an auto-array. This means that we only allocate
when the max span is large, but this means we either would do a larger
allocation before, or do more iterations now. At least now, we don't
allocate a big array for a single span, and the complexity of the
iteration is linear with the number of spans in total, which is already
the complexity of step 3.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2abf05710e06
Remove explicitly stored per-span data from nsGridContainerFrame::Tracks::ResolveIntrinsicSize r=dholbert

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/2abf05710e06