1933921 - SVG shortcut favicon on new tab page is cropped on the top and bottom

Status: NEW

(Firefox :: New Tab Page, defect, P3)

Description

[Kestrel]

Attachment: Comparison showing SVG icon being cropped on the new tab page

STR:

1. Pin https://www.cbsnews.com to the new tab page shortcuts.

Expected:
CBS icon is fully visible with a circular outer perimeter.

Actual:
CBS icon has a flat top and bottom indicating it is being cropped.

Occurs at all zoom levels. The image was previously PNG but recently changed to SVG.

Also occurs on about:firefoxview but requires zooming to notice and mostly affects the bottom edge.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=47b1ae23989b8389b90ec9fed715d9eae6455ad7&tochange=ec6364b47f312809587d58ec8fe38e02d7f78976

Regressed by Bug 1494016.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:yazan, since you are the author of the regressor, bug 1494016, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Marco Bonardo [:mak]]

I don't think this is effectively a regression (in the sense the newly modified code is not wrong), we're just picking a different favicon and this uncovered a bug in how new tab handles this svg.
I'm moving the bug to NewTab, as I think there should be no problem using an svg, and this happening may allow investigating why such an icon gets cropped.
Though this is pretty much the same as Bug 1933158, this is a mask-icon and Places should not store it for now, fixing that bug should shortly return to the old png.

Comment 3

[Kestrel]

Attachment: Bottom of SVG icon cropped in history sidebar

It would also need to be fixed in the history sidebar and about:firefoxview. Tab and bookmark icons are unaffected.