1933966 - empty group doesn't removed from closedGroups when closed tabs restored one at a time

Status: RESOLVED FIXED

(Firefox :: Session Restore, defect, P2)

Description

[tabmix.onemen]

Bug 1927774 add the ability to restore tabs form closed tab group.

After restoring all tabs from a deleted group SessionStrore does not remove the group from winData.closedGroups

The result of this 'ghost' group is that any attempt to reopen other closed tabs when there are other closed groups fails with this error

Uncaught NS_ERROR_ILLEGAL_VALUE: Invalid index: not in the closed tabs
    ssi_undoCloseTab resource:///modules/sessionstore/SessionStore.sys.mjs:4079
    ss_undoCloseTab resource:///modules/sessionstore/SessionStore.sys.mjs:449
    undoCloseTab chrome://browser/content/browser.js:6042
    oncommand chrome://browser/content/browser.xhtml:1
2 SessionStore.sys.mjs:4079

Steps to reproduce:

• open few tabs
• create group
• delete the group
• go to History > Recently Closed Tabs and restore each tab from that group.
• create another group and delete it.

Result:

• any call to undoCloseTab() will fail with the above error

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:sthompson, since you are the author of the regressor, bug 1927774, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Stephen Thompson [:sthompson]]

This is not really a regression -- this is a bug with new functionality that's behind a feature flag.

This is definitely an oversight from the implementation. If a tab is restored from a closed group and that causes the closed group to have no more remaining tabs, we should remove the closed group data from the session.

Comment 3

[Stephen Thompson [:sthompson]]

I think that if bug 1927765 is resolved, this specific bug will be fixed.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:sclements, could you have a look please?

For more information, please visit BugBot documentation.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Is this fixed now that bug 1927765 is fixed?

Comment 6

[tabmix.onemen]

YES,
it is fixed by bug 1927765