1934118 - start.me - scroll with mouse wheel stops working

Status: RESOLVED FIXED

(Core :: Layout: Scrolling and Overflow, defect, P2)

Description

[Alice0775 White]

Steps to reproduce:

1. Open https://about.start.me/
2. Click on Create Your Free Start Page
3. Sign up or Login with google/facebook etc.
4. Add widget > Newsfeed(RSS) > Select any one then Add Feed
5. If the page is not scrollable (not enough content), repeat Step 4.
6. Try to scroll the page with mouse wheel

OR

1. Open https://start.me/p/xbzmvw/start
2. Try to scroll the page with mouse wheel

Actual results:
Cannot scroll

Expected Results:
Page is scrolled

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e19e97284fdc776da8a3fa5ed320026130358ee4&tochange=5b6fb5d517d3b05079e470ce807390cc7db203ab

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:hiro, since you are the author of the regressor, bug 1922904, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Alice0775 White]

Workaround: CSS scroll-snap-type value to none instead of x mandatory

.widget-page__main {
  scroll-snap-type: none; /*x mandatory;*/
}

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Thank you Alice for the duplication. This bug is kinda between S2 and S3, there's a workaround to scroll by dragging the scroll thumb, but anyways the symptoms are quite bad.

I have started looking into this, but I haven't figured out any ways to solve this unfortunately.

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1934118 - Tweak the returned value of GetSnapPointForDestination. r?botond

Since bug 1922904, GetSnapPointForDestination had returned an ineligible
snap point.

For exmaple, given that there's a scroll container only wants to snap
horizontally and there are 3 snap target points, (0, 0), (100, 0) and
(200,0). Then if the user tries to scroll vertically to (0, 100), the
function returned (0, 0) as a valid snap position for the vertical scroll
operation. With this change the function now returns (0, 100) so that
the user can scroll vertically to the correct position.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3870f21337b
Tweak the returned value of GetSnapPointForDestination. r=dlrobertson

Comment 7

[Norisz Fay [:noriszfay]]

Backed out for causing mochitest failure on test_group_scroll_snap.html

Backout link

Push with failures

Failure log

Comment 8

[Hiroyuki Ikezoe (:hiro)]

I somehow used a wrong scrollend event target in the test, maybe during tidying up the test. :/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34a32a58c71c
Tweak the returned value of GetSnapPointForDestination. r=dlrobertson

Comment 10

[amarc]

https://hg.mozilla.org/mozilla-central/rev/34a32a58c71c

Comment 11

[Atila Butkovits]

Backed out for causing failures at test_group_scroll_snap.html.

Backout link: https://hg.mozilla.org/integration/autoland/rev/6f22a74ee74761f2203fed03c0e2b3c7f44e6e5f

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=34a32a58c71c9d4e5d8ea82d5f730cf89f54a404

Failure log: https://treeherder.mozilla.org/logviewer?job_id=486866129&repo=autoland&lineNumber=11559

Comment 12

[Hiroyuki Ikezoe (:hiro)]

NativePanHandler.delta is quite confusing on mac. :/

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/edaa74df3d63
Tweak the returned value of GetSnapPointForDestination. r=dlrobertson

Comment 14

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/edaa74df3d63

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:hiro, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox134 to wontfix.

For more information, please visit BugBot documentation.

Comment 16

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 9441588 [details]
Bug 1934118 - Tweak the returned value of GetSnapPointForDestination. r?botond

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: Users can't scroll on some kind of sites
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The code change is very small, and done in a very limited place, it will not have any impacts widely.
• String changes made/needed: none
• Is Android affected?: Yes

Comment 17

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9441588 [details]
Bug 1934118 - Tweak the returned value of GetSnapPointForDestination. r?botond

Not being able to scroll some sites sounds bad. Approved for 134 RC so we don't ship this new regression.

Comment 18

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/44bea1d33e28