1934226 - If in a city name there is no space after "." or space on both sides, the city is also interpreted as a subject

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Attachment: dot in city name.mp4

[Affected versions]:

• Firefox Nightly 135.0a1 - Build ID: 20241128215411
• Firefox Beta 134.0b3

[Affected Platforms]:

• Windows 10
• macOS 14.4.1
• Linux Mint 20.1

[Prerequisites]:

• Have following prefs set:
  • browser.search.region = US
  • browser.urlbar.yelp.mlEnabled = true
  • browser.urlbar.quicksuggest.mlEnabled = true
  • browser.ml.enable = true

[Steps to reproduce]:

1. Open the browser using the profile from the prerequisites.
2. Type in the addressbar the "plumber in st.louis" or "plumber in st . louis" keywords.
3. Observe the results triggered in the "Firefox Suggest" section.

[Expected result]:

• The Yelp suggestion is triggered and displayed as: "plumber in St. Louis, MO".

[Actual result]:

• The Yelp suggestion is triggered and displayed as: "plumber in st louis in St. Louis, MO".

[Notes]:

• Attached is a screen recording of the issue.

Comment 1

[cgopal]

Attachment: Bug 1934226 - If in a city name there is no space after "." or space on both sides, the city is also interpreted as a subject r?adw,tarek

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7dafc0ccf79d
If in a city name there is no space after "." or space on both sides, the city is also interpreted as a subject r=adw,urlbar-reviewers

Comment 3

[cgopal]

Comment on attachment 9441119 [details]
Bug 1934226 - If in a city name there is no space after "." or space on both sides, the city is also interpreted as a subject r?adw,tarek

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: This is required for Yelp ML suggestions in the address bar, which we want to experiment with in 134
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: https://bugzilla.mozilla.org/attachment.cgi?id=9440715
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Very low risk: Has a test. Only affects Yelp ML suggestions, which are preffed off.
• String changes made/needed:
• Is Android affected?: No

Comment 4

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/7dafc0ccf79d

Comment 5

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue on the latest Nightly 135.0a1 (Build ID: 20241204215713) on Windows 10 x64, macOS 14.4.1 and Linux Mint 20.1.

• The Yelp suggestion is correctly triggered and displayed and the city is no longer interpreted as a subject

I will leave the "qe-verify" flag set until I will verify the bug in Beta after it is uplifted.

Comment 6

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/8cbbc22371d8

Comment 7

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue on the latest Beta 134.0b7 (Build ID: 20241206102218) on Windows 10 x64, macOS 14.4.1 and Linux Mint 20.1.

• The Yelp suggestion is correctly triggered and displayed, and the city is no longer interpreted as a subject.