1934300 - [wpt-sync] Sync PR 49444 - Fix crash on calc() in grid rows/columns.

Status: RESOLVED FIXED

(Core :: Layout: Grid, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 49444 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/49444
Details from upstream follow.

Steinar H. Gunderson <[e-mail]> wrote:

Fix crash on calc() in grid rows/columns.

Seemingly we already have clamping and all in place computed-value
time, so we just to avoid calling GetIntValue() during parsing.

Note that a test discovered that GetValueIfKnown() did not round
the same way GetDoubleValue() evidently does, so we needed to fix
that.

Bug: 40946458
Change-Id: I51eb467196853cc88ce52d7f307b3aaf7cae4261
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6059011
Commit-Queue: Daniil Sakhapov \<[e-mail]>
Auto-Submit: Steinar H Gunderson \<[e-mail]>
Reviewed-by: Daniil Sakhapov \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1389876}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=989485bf9efd7b1dad19802b49b03066da09759c

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL : 1

Chrome

OK : 1
PASS : 1

Safari

CRASH: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-grid/computed-grid-column.html [wpt.fyi]
  • CSS Grid Layout Test: row/column is complex calc(): FAIL (Chrome: PASS)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/465a6385dec0
[wpt PR 49444] - Fix crash on calc() in grid rows/columns., a=testonly
https://hg.mozilla.org/integration/autoland/rev/3ddae9287565
[wpt PR 49444] - Update wpt metadata, a=testonly

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/465a6385dec0
https://hg.mozilla.org/mozilla-central/rev/3ddae9287565