1934326 - "waitForCurrentWindowGlobal()" should check for discarded browser to not unnecessarily wait for the window global

Status: RESOLVED FIXED

(Remote Protocol :: Agent, defect, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

As discovered by reviewing https://phabricator.services.mozilla.com/D230661 I noticed that we unnecessarily wait extra 100ms in waitForCurrentWindowGlobal() if the actual window was already closed. This can hopefully be easily fixed by checking if the browsing context is discarded - but note that this flag can be set to true as well if there is a cross-origin navigation. So we need to be careful.

When we can remove the 100ms delay we should also update the BiDi tests as added by https://phabricator.services.mozilla.com/D230663 so that they no longer have to delay by 250ms but just 100ms.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Due to the risk of regressions it would be good to wait landing any patch until the next cycle early next year with cycle.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I just stumbled over the 250ms timeout in the perform actions wdspec tests while doing a review and thought about to give it a try. Given that I cannot reproduce locally I pushed a try build to get some debug information. Lets see if it still reproduces with MacOS 14.70.

https://treeherder.mozilla.org/jobs?repo=try&searchStr=platform%2Copt&revision=fe33b092ac8b36b49a3cf92a81fcc319b51705bc

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I've reduced the pause from 250ms to just 100ms but I'm not able to get into a state when the currentWindowGlobal is not defined. As such I also cannot reproduce the extra delay locally. As such I've pushed a try build with a debug line to see if we actually hit this case and if yes which test is triggering it:

https://treeherder.mozilla.org/jobs?repo=try&landoCommitID=170339

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1934326 - [remote] Check for browsing context discarded in "waitForCurrentWindowGlobal()".

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1934326 - [wdspec] Sync duration of pause in action test for closing a browsing context with WebDriver classic.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c7904291c05c
https://hg.mozilla.org/integration/autoland/rev/998ca8902bdf
[remote] Check for browsing context discarded in "waitForCurrentWindowGlobal()". r=Sasha
https://github.com/mozilla-firefox/firefox/commit/e21815e6380e
https://hg.mozilla.org/integration/autoland/rev/fb5f293bbbbb
[wdspec] Sync duration of pause in action test for closing a browsing context with WebDriver classic. r=Sasha

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/56905 for changes under testing/web-platform/tests

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/998ca8902bdf
https://hg.mozilla.org/mozilla-central/rev/fb5f293bbbbb

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot