1934326 - "waitForCurrentWindowGlobal()" should check for discarded browser to not unnecessarily wait for the window global

Status: NEW

(Remote Protocol :: Agent, defect, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

As discovered by reviewing https://phabricator.services.mozilla.com/D230661 I noticed that we unnecessarily wait extra 100ms in waitForCurrentWindowGlobal() if the actual window was already closed. This can hopefully be easily fixed by checking if the browsing context is discarded - but note that this flag can be set to true as well if there is a cross-origin navigation. So we need to be careful.

When we can remove the 100ms delay we should also update the BiDi tests as added by https://phabricator.services.mozilla.com/D230663 so that they no longer have to delay by 250ms but just 100ms.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Due to the risk of regressions it would be good to wait landing any patch until the next cycle early next year with cycle.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I just stumbled over the 250ms timeout in the perform actions wdspec tests while doing a review and thought about to give it a try. Given that I cannot reproduce locally I pushed a try build to get some debug information. Lets see if it still reproduces with MacOS 14.70.

https://treeherder.mozilla.org/jobs?repo=try&searchStr=platform%2Copt&revision=fe33b092ac8b36b49a3cf92a81fcc319b51705bc