1934482 - There is no scrollbar in the "Manage History" window/popup until you try some radom things (switch back and forth, change focus, etc.)

Status: VERIFIED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Mayank Bansal]

Go to Hamburger Menu -> History ->Manage History

AR: In the right-hand pane (where the history entries appear), there is no scroll-bar.
ER: There should be a scrollbar

To bring the scroll-bar, you need to do some random things like switch windows back-and-forth, or change focus using the tab key, etc.

Bisection:

Bug 1805367 - Prevent text input from overlapping scrollbar in tree widget. r=dholbert,desktop-theme-reviewers,reusable-components-reviewers,dao,mstriemer

Differential Revision: https://phabricator.services.mozilla.com/D225558

Comment 1

[Mayank Bansal]

Attachment: about:support

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1805367

Comment 3

[Mayank Bansal]

Attachment: bandicam-2024-12-02-10-05-18-139.av1.mp4

Comment 4

[Alice0775 White]

[Tracking Requested - why for this release]: no scrollbar is shows on Library, sidebar and Certificate Manager.

Comment 5

[Alice0775 White]

On Windows11:
Since 133.0, scroll thumb no longer appear.

On Kubuntu24.04:
when the library/sidebar is opened, the scroll thumb should appear for a few seconds. However, Since 133.0, it no longer does.

Comment 6

[Tim Giles [:tgiles] | OOO Dec 19 - Jan 6]

This is a tricky issue to investigate, doesn't reproduce in Windows 10 since the overlay scrollbars don't behave the same way as in Windows 11 and Linux (and most likely macOS but I didn't verify on macOS). Following mozregression, I get the same commit from Comment #0, Bug 1805367. However, if I revert the regressing commit on a commit from today's mozilla-central, the issue still appears....which is odd because my commit for Bug 1805367 should be causing this issue, given the two independent bisections. I think this might be a regression from Bug 1925491, or at least related to it. If I run mozregression --launch 2024-10-18, then this scrollbar issue isn't present and they behave as expected in the Library window (and in the search engines section in about:preferences). When I run mozregression --launch 2024-10-20 the scrollbar issue mentioned in Comment #0 reproduces consistently. Changing the height and width of the History window seems to cause the scrollbar to appear (if it didn't render when the window first opened), but then there's the odd behavior of trying to hover on the scrollbar. After a few seconds of hovering on the scrollbar, it becomes inactive and disappears.

My current guess is that the markup change in tree.js for Bug 1925491 is causing some odd calculation for determining if the scrollbar in the widget is being hovered or not. I can't confirm that though, just my current best guess.

:emilio, do you have any insight as to why tree widget is causing its vertical overlay scrollbar to disappear, or not render at all? I'm not sure what else to look for at this point.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox133 (release). However, the bug still isn't assigned.

:pluk, could you please find an assignee for this tracked bug? Given that it is a regression and we know the cause, we could also simply backout the regressor. If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 8

[Emilio Cobos Álvarez [:emilio]]

Are you sure? If I revert just the CSS part of your bug the bug goes away for me:

diff --git a/toolkit/themes/shared/tree/tree.css b/toolkit/themes/shared/tree/tree.css
index 8959b90477837..54a53c36de933 100644
--- a/toolkit/themes/shared/tree/tree.css
+++ b/toolkit/themes/shared/tree/tree.css
@@ -259,10 +259,6 @@ html|input.tree-input {
 .scrollbar-topmost {
   position: relative;
   z-index: 2147483647;
-
-  &[collapsed="true"] {
-    display: none;
-  }
 }

 /* ::::: sort direction indicator :::::  */

Which makes a lot of sense because the tree widget searches for scrollbars using the frame tree, and display: none makes them not have a frame:

https://searchfox.org/mozilla-central/rev/ed26560fef073fd3f5e951fcadf5c2620778b00a/layout/xul/tree/nsTreeBodyFrame.cpp#766-769

I don't think you should be setting display: none. Scrollbars use collapsed for a reason (to get visibility: collapse behavior while not losing the frame).

Comment 12

[Donal Meehan [:dmeehan]]

:mstriemer, tagging as triage owner, could this be triaged for severity/priority?

The Fx133 planned dot release builds on Monday 2024-12-09. There is little time to fix this if we can include something.

Comment 13

[Tim Giles [:tgiles] | OOO Dec 19 - Jan 6]

Attachment: Ubuntu 22.04.5 X11 scrollbar disappears on hover with regressing bug reverted

:emilio, what's your Linux configuration? Reverting my patch from Bug 1805367 still has the missing scrollbar issue on Ubuntu 22.04 X11. I'm currently building from this recent mozilla-central commit, https://hg.mozilla.org/mozilla-central/rev/233e73a17c3f7d9f9cbb3fc3dc7f8af9cad499ff, so I have no idea what is going on now.

Attached is a screencast of the issue I'm seeing even when Bug 1805367 reverted locally. I'm not sure where to go from here nor do I understand what is actually causing this issue in the first place.

Comment 14

[Emilio Cobos Álvarez [:emilio]]

I'm very confused, doesn't your screencast show the bug fixed? I see the scrollbars just fine there (unlike without the revert)? What are you seeing broken there (compared to something pre-regression like mozregression --launch 130)?

The scrollbar is supposed to disappear if your mouse is not over the <tree>, that's how these work on Linux and Win11 generally. But with your patch reverted the scrollbar appears on mouseover or scroll (unlike on current central).

Comment 15

[Alice0775 White]

Please backed out the offending Bug 1805367. This bug is very annoyance.

Comment 16

[Donal Meehan [:dmeehan]]

The regressor Bug 1805367 will be backed out of central, beta, and release.
We will update the flags was we go and the the backout will be included in the next Fx133 dot release scheduled to release on 2024-12-10
Beta backout: https://hg.mozilla.org/releases/mozilla-beta/rev/ec541f21412133784b168da3fd145d851311b886
Autoland backout: https://hg.mozilla.org/integration/autoland/rev/2755665ef1727158f5e8707a837d14be6eed3968

Comment 17

[Tim Giles [:tgiles] | OOO Dec 19 - Jan 6]

Attachment: mozregression --launch 130 showing scrollbar does not disappear on hover

Using mozregression --launch 130, the scrollbars are there and they don't disappear on hover unlike in the current central. Went ahead and requested a backout of the regressing patch as I'm confused as to what the expected behavior for these scrollbars should be (other than that they should be present).

Comment 20

[Donal Meehan [:dmeehan]]

The regressor Bug 1805367 was backed out release for the planned dot release 133.0.3
Release backout: https://hg.mozilla.org/releases/mozilla-release/rev/e051b8a9900a6ecaaf667b92ba504a87d8027801

Comment 22

[Mark Striemer [:mstriemer]]

The regressing bug was backed out, this bug is no longer occurring.

Comment 23

[Mayank Bansal]

(usually these are marked as "Fixed by backout"). I am changing status, but please change if you disagree.