1934497 - [Wayland] Implement WaylandSurface to render to screen on Linux

Status: RESOLVED FIXED

(Core :: Widget: Gtk, enhancement, P3)

Description

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Implement WaylandSurface to provide unified way to render on screen on Linux. That will be used by Webrender/GL, SW rendering and Webrender compositor (native layers). Unified rendering ensures we use the same codepath and will fix bugs in Wayland native layers implementation.

Comment 1

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Attachment: Bug 1934497 [Wayland] Update nsAppShell logging r?emilio,rmader

• Change VSync modile logging name from WidgetVsync to WidgetVSync
• Add WidgetCompositor logging module

Comment 2

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Attachment: Bug 1934497 [Wayland] Add GdkWindow to traits to use it with RefPtr r?emilio,rmader

Comment 3

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Attachment: Bug 1934497 [Wayland] Allow to run GetDesktopEnvironmentIdentifier() from different threads r?emilio,rmader

Comment 4

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Attachment: Bug 1934497 [Wayland] Implement wl_surface abstraction as WaylandSurface r?emilio,rmader

Comment 5

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Attachment: Bug 1934497 [Wayland] Implement WaylandSurface lock as WaylandSurfaceLock class r?emilio,rmader

Allow to lock WaylandSurface and does wl_surface commit if requested on unlock.

Comment 6

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Attachment: Bug 1934497 [Wayland] Udate WaylandBuffer to work with WaylandSurface and implement WaylandBufferDMABUF r?emilio,rmader

Comment 7

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Attachment: Bug 1934497 [Wayland] Move wl_surface management from MozContainerWayland to WaylandSurface and reference it from MozContainerWayland r?emilio,rmader

Comment 8

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Attachment: Bug 1934497 [Wayland] Update WindowSurfaceWaylandMultiBuffer to work with WaylandSurface r?emilio,rmader

Comment 9

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Attachment: Bug 1934497 [Wayland] Rework WaylandVsyncSource for WaylandSurface r?emilio,rmader

Use persistent WaylandSurface frame callback to fire VSync events.

Comment 10

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Attachment: Bug 1934497 [Wayland] Make nsWindow to use WaylandSurface and new VSync interface r?emilio,rmader

• Make nsWindow own WaylandSurface which makes sure we don't release it too early as is reffed
• Always get scale factor from parent nsWindow for popups, don't try to guess
• Simplify VSync management
• Use Verbose logging level for extra size/scale messages

Comment 11

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Attachment: Bug 1934497 [Wayland] Switch MozContainerSurfaceLock for WaylandSurfaceClock at RenderCompositorEGL r?emilio,rmader

Comment 12

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Attachment: Bug 1934497 [Wayland] Temporary disable layer rendering r?emilio,rmader

We'll update WaylandNativeLayers for WaylandSurface in next patches.

Comment 13

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Attachment: Bug 1934497 [Wayland] Update GtkCompositorWidget for WaylandSurface r?emilio,rmader

• Replace MozContainerSurfaceLock with WaylandSurfaceLock
• Temporary disable GtkCompositorWidget::GetNativeLayerRoot()

Comment 14

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Attachment: Bug 1934497 [Wayland] Propagate HDR info from WaylandDisplay to Screen r?emilio,rmader

• We may need to provide HDR info per monitor but for now it's enough to just enable it globally to get it working.

Comment 15

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Attachment: Bug 1934497 [Wayland] Use wl_surface owned by Gtk to set Wayland WakeLockListener r?emilio,rmader

Comment 16

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Attachment: Bug 1934497 [Wayland] Remove MozContainerSurfaceLock r?emilio,rmader

Comment 17

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f6e3668fd4636b47c7a8aa2cbbfaa8da38ae2092

Comment 18

[Robert Mader [:rmader]]

@ Martin: I'm following this with great interest, but unfortunately lack the bandwidth to do in-depth reviewing atm., sorry :/

Comment 19

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

(In reply to Robert Mader [:rmader] from comment #18)

@ Martin: I'm following this with great interest, but unfortunately lack the bandwidth to do in-depth reviewing atm., sorry :/

Not a problem, it can be adjusted any time later.

Comment 20

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=24d906f525f05ce5ae16cd7d6527cb38d57f1a23

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59b2a1f052e4
[Wayland] Update nsAppShell logging r=emilio
https://hg.mozilla.org/integration/autoland/rev/fe1e2b1b4f8b
[Wayland] Add GdkWindow to traits to use it with RefPtr r=emilio
https://hg.mozilla.org/integration/autoland/rev/f6ea1323c158
[Wayland] Allow to run GetDesktopEnvironmentIdentifier() from different threads r=emilio
https://hg.mozilla.org/integration/autoland/rev/2fbec9faf49c
[Wayland] Implement wl_surface abstraction as WaylandSurface r=emilio
https://hg.mozilla.org/integration/autoland/rev/a1cf316b3e7a
[Wayland] Implement WaylandSurface lock as WaylandSurfaceLock class r=emilio
https://hg.mozilla.org/integration/autoland/rev/d6e7e274dda3
[Wayland] Udate WaylandBuffer to work with WaylandSurface and implement WaylandBufferDMABUF r=emilio
https://hg.mozilla.org/integration/autoland/rev/bbe16df11895
[Wayland] Move wl_surface management from MozContainerWayland to WaylandSurface and reference it from MozContainerWayland r=emilio
https://hg.mozilla.org/integration/autoland/rev/4f50bd47febd
[Wayland] Update WindowSurfaceWaylandMultiBuffer to work with WaylandSurface r=emilio
https://hg.mozilla.org/integration/autoland/rev/739018e9ae4a
[Wayland] Rework WaylandVsyncSource for WaylandSurface r=emilio
https://hg.mozilla.org/integration/autoland/rev/ed34f4ff5a2b
[Wayland] Make nsWindow to use WaylandSurface and new VSync interface r=emilio
https://hg.mozilla.org/integration/autoland/rev/2f0971ca8b41
[Wayland] Switch MozContainerSurfaceLock for WaylandSurfaceClock at RenderCompositorEGL r=emilio
https://hg.mozilla.org/integration/autoland/rev/6225ae4714a9
[Wayland] Temporary disable layer rendering r=emilio
https://hg.mozilla.org/integration/autoland/rev/31f0a398817f
[Wayland] Update GtkCompositorWidget for WaylandSurface r=emilio
https://hg.mozilla.org/integration/autoland/rev/e535888994ed
[Wayland] Propagate HDR info from WaylandDisplay to Screen r=emilio
https://hg.mozilla.org/integration/autoland/rev/e6b221a0e987
[Wayland] Use wl_surface owned by Gtk to set Wayland WakeLockListener r=emilio
https://hg.mozilla.org/integration/autoland/rev/b2f82cada9b0
[Wayland] Remove MozContainerSurfaceLock r=emilio

Comment 22

[Norisz Fay [:noriszfay]]

Backed out for causing Wayland related mochitest failures and bustage on WaylandSurface.cpp and Bug 1936214

Backout link

Push with failures

Failure log 1 // Failure log 2 // Failure log 3 // Failure log 4 // Failure log 5

Comment 24

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

For the leak it looks like WaylandSurface is references by unreleased VSyncSource. Not sure why it's kept around.

Comment 25

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

(In reply to Martin Stránský [:stransky] (ni? me) from comment #24)

For the leak it looks like WaylandSurface is references by unreleased VSyncSource. Not sure why it's kept around.

Hm, looks like popups is the issue as VSync is cleared. Perhaps popup holds strong ref to parent which is not released.

Comment 26

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Looks like the memleaks are caused by compositor bug when wl_buffer is not released. Updated. Let's see if Wayland try is clean this run:

Comment 27

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a89625888da2d96de475de8c90bd4f11c982f854

Comment 28

[Intermittent Failures Robot]

Summary

4 failures in 4615 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 4

Platform and build breakdown:

• linux64: 4
  • opt: 4

Table

	1proc	1proc-s	1proc-swr	a11y-checks	a11y-checks-s	a11y-checks-swr	a11y-checks-swr-s	condprof	condprof-s	fis	fis-hv	fis-hv-s	fis-s	headless	headless-s	http2	http3	mda-gpu	msix	msix-s	no_variant	nofis	nofis-aab	nofis-s	nofis-ship	nofis-ship-s	nofis-spi	nofis-swr	nofis-swr-s	nogpu	nogpu-s	s	spi	spi-nw	spi-nw-1proc	spi-nw-nofis	spi-nw-nofis-s	spi-nw-s	spi-s	swr	swr-s	wmfme	wr-dc1-p	xorig	xorig-s
linux64/opt																					4

For more details, see:

https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1934497&startday=2024-12-09&endday=2024-12-15&tree=all

Comment 29

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ba05279a465
[Wayland] Update nsAppShell logging r=emilio
https://hg.mozilla.org/integration/autoland/rev/191397418056
[Wayland] Add GdkWindow to traits to use it with RefPtr r=emilio
https://hg.mozilla.org/integration/autoland/rev/75d095afa9cf
[Wayland] Allow to run GetDesktopEnvironmentIdentifier() from different threads r=emilio
https://hg.mozilla.org/integration/autoland/rev/693a7c400778
[Wayland] Implement wl_surface abstraction as WaylandSurface r=emilio
https://hg.mozilla.org/integration/autoland/rev/c0512daa9188
[Wayland] Implement WaylandSurface lock as WaylandSurfaceLock class r=emilio
https://hg.mozilla.org/integration/autoland/rev/dcef70581e34
[Wayland] Udate WaylandBuffer to work with WaylandSurface and implement WaylandBufferDMABUF r=emilio
https://hg.mozilla.org/integration/autoland/rev/ff8a92afd360
[Wayland] Move wl_surface management from MozContainerWayland to WaylandSurface and reference it from MozContainerWayland r=emilio
https://hg.mozilla.org/integration/autoland/rev/6806bbf97c86
[Wayland] Update WindowSurfaceWaylandMultiBuffer to work with WaylandSurface r=emilio
https://hg.mozilla.org/integration/autoland/rev/5343854a37e5
[Wayland] Rework WaylandVsyncSource for WaylandSurface r=emilio
https://hg.mozilla.org/integration/autoland/rev/a9a38191e649
[Wayland] Make nsWindow to use WaylandSurface and new VSync interface r=emilio
https://hg.mozilla.org/integration/autoland/rev/eea0eef40abf
[Wayland] Switch MozContainerSurfaceLock for WaylandSurfaceClock at RenderCompositorEGL r=emilio
https://hg.mozilla.org/integration/autoland/rev/87613cc32aa4
[Wayland] Temporary disable layer rendering r=emilio
https://hg.mozilla.org/integration/autoland/rev/2bf4f54a3077
[Wayland] Update GtkCompositorWidget for WaylandSurface r=emilio
https://hg.mozilla.org/integration/autoland/rev/e6917a8311f2
[Wayland] Propagate HDR info from WaylandDisplay to Screen r=emilio
https://hg.mozilla.org/integration/autoland/rev/6aff7ffeaff4
[Wayland] Use wl_surface owned by Gtk to set Wayland WakeLockListener r=emilio
https://hg.mozilla.org/integration/autoland/rev/795745f450df
[Wayland] Remove MozContainerSurfaceLock r=emilio

Comment 30

[agoloman]

Backed out for causing mass failures.

• Backout link
• Push with failures
• Failure Log

Comment 31

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Updated, Thanks.

Comment 32

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e9080fd1c7c
[Wayland] Update nsAppShell logging r=emilio
https://hg.mozilla.org/integration/autoland/rev/3e0c8eec4b20
[Wayland] Add GdkWindow to traits to use it with RefPtr r=emilio
https://hg.mozilla.org/integration/autoland/rev/84186392210d
[Wayland] Allow to run GetDesktopEnvironmentIdentifier() from different threads r=emilio
https://hg.mozilla.org/integration/autoland/rev/e87a5169f668
[Wayland] Implement wl_surface abstraction as WaylandSurface r=emilio
https://hg.mozilla.org/integration/autoland/rev/8cc721cc8bc5
[Wayland] Implement WaylandSurface lock as WaylandSurfaceLock class r=emilio
https://hg.mozilla.org/integration/autoland/rev/b72ae2651fad
[Wayland] Udate WaylandBuffer to work with WaylandSurface and implement WaylandBufferDMABUF r=emilio
https://hg.mozilla.org/integration/autoland/rev/395f7e887b81
[Wayland] Move wl_surface management from MozContainerWayland to WaylandSurface and reference it from MozContainerWayland r=emilio
https://hg.mozilla.org/integration/autoland/rev/4e2fe326671e
[Wayland] Update WindowSurfaceWaylandMultiBuffer to work with WaylandSurface r=emilio
https://hg.mozilla.org/integration/autoland/rev/1c53bbe84cda
[Wayland] Rework WaylandVsyncSource for WaylandSurface r=emilio
https://hg.mozilla.org/integration/autoland/rev/4e75ec1344b9
[Wayland] Make nsWindow to use WaylandSurface and new VSync interface r=emilio
https://hg.mozilla.org/integration/autoland/rev/c3b9163075af
[Wayland] Switch MozContainerSurfaceLock for WaylandSurfaceClock at RenderCompositorEGL r=emilio
https://hg.mozilla.org/integration/autoland/rev/18df8a1298f6
[Wayland] Temporary disable layer rendering r=emilio
https://hg.mozilla.org/integration/autoland/rev/4a1a1cbab703
[Wayland] Update GtkCompositorWidget for WaylandSurface r=emilio
https://hg.mozilla.org/integration/autoland/rev/dd6f161a2dd0
[Wayland] Propagate HDR info from WaylandDisplay to Screen r=emilio
https://hg.mozilla.org/integration/autoland/rev/5e231ba0d046
[Wayland] Use wl_surface owned by Gtk to set Wayland WakeLockListener r=emilio
https://hg.mozilla.org/integration/autoland/rev/f9a6fb8bae13
[Wayland] Remove MozContainerSurfaceLock r=emilio

Comment 33

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Attachment: Bug 1934497 [Wayland] Fix build bustage on release r?emilio

Comment 34

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Attachment: Bug 1934497 [Wayland] Fix non unified build bustage r?emilio

Comment 35

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/58a807c8fde7
[Wayland] Fix build bustage on release r=emilio
https://hg.mozilla.org/integration/autoland/rev/8af28b4f8ccb
[Wayland] Fix non unified build bustage r=emilio CLOSED TREE

Comment 36

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/2e9080fd1c7c
https://hg.mozilla.org/mozilla-central/rev/3e0c8eec4b20
https://hg.mozilla.org/mozilla-central/rev/84186392210d
https://hg.mozilla.org/mozilla-central/rev/e87a5169f668
https://hg.mozilla.org/mozilla-central/rev/8cc721cc8bc5
https://hg.mozilla.org/mozilla-central/rev/b72ae2651fad
https://hg.mozilla.org/mozilla-central/rev/395f7e887b81
https://hg.mozilla.org/mozilla-central/rev/4e2fe326671e
https://hg.mozilla.org/mozilla-central/rev/1c53bbe84cda
https://hg.mozilla.org/mozilla-central/rev/4e75ec1344b9
https://hg.mozilla.org/mozilla-central/rev/c3b9163075af
https://hg.mozilla.org/mozilla-central/rev/18df8a1298f6
https://hg.mozilla.org/mozilla-central/rev/4a1a1cbab703
https://hg.mozilla.org/mozilla-central/rev/dd6f161a2dd0
https://hg.mozilla.org/mozilla-central/rev/5e231ba0d046
https://hg.mozilla.org/mozilla-central/rev/f9a6fb8bae13
https://hg.mozilla.org/mozilla-central/rev/58a807c8fde7
https://hg.mozilla.org/mozilla-central/rev/8af28b4f8ccb