1934591 - [HCM] Focus ring missing on Themes in Edit/Create profile pages on Windows

Status: RESOLVED WORKSFORME

(Toolkit :: Startup and Profile System, defect)

Description

[Simona Badau, Desktop QA]

Attachment: Screenshot with the issue

Found in

• Nightly 135.0a1

Affected versions

• Nightly 135.0a1

Tested platforms

• Affected platforms: Windows 11, Windows 10.
• Unaffected platforms: macOS 15.

Preconditions

• Ensure that the pref "browser.profiles.enabled" is set to true in about:config.
• Create one profile using Profile Switching.
• Enable High Contrast Mode in the OS.

Steps to reproduce

1. Open the Profiles panel from the Hamburger menu.
2. Click the Edit button.
3. Set a new theme.

Expected result

• A focus ring should be visible on both the previously enabled theme and the newly selected theme.

Actual result

• The focus ring is not visible, making it difficult to identify the enabled theme.

Regression range

• This is not a regression; it's introduced with the Profile Switching feature.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:mossop, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Cieara Meador [:cmkm]]

Attachment: A screenshot of the new/edit profile menu, with Moss as the enabled theme and focus on the Lavender theme card.

As of 136 I'm seeing a focus ring as expected, but the HCM styling still isn't quite where it should be per figma. Recommend fixing this in Bug 1936671 and marking this bug closed afterwards.

A focus ring should be visible on both the previously enabled theme and the newly selected theme.

I want to clarify this. The current design does not reflect a focus ring around the previously enabled theme, and I don't think showing multiple focus rings is the right UX. Is this out of date?

Comment 3

[misha [:mbruk]]

thanks for flaggin! there shouldn't be multiple focus rings on these chips at the same time. the figma is still up to date :) a user can have a separate chip selected vs focused but that styling isn't currently reflected in the screenshot. let me know if getting on a quick call would be helpful to walk through it

Comment 4

[Cieara Meador [:cmkm]]

Since the original issue isn't reproducible anymore, I'll mark this closed and note that additional updates to this surface's HCM treatment are happening in Bug 1936671.