1934594 - [wpt-sync] Sync PR 49464 - TransformPositionArea() incorrectly assumed two-value input

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 49464 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/49464
Details from upstream follow.

Rune Lillesveen <[e-mail]> wrote:

TransformPositionArea() incorrectly assumed two-value input

Crashed when input was not a pair, but assumed it would be.

For logical values like position-area:start, we can store the value as
a single keyword, but the flip-block version of it needs to be two
separate values.

position-area might be represented as a single keyword depending on
which it is, but it's irrelevant whether the non-flipped value was a
single keyword or two keywords. For simplicity keep identical values.

Bug: 380321441
Change-Id: I29b91e7cc6dd7bea286f11475382117afb872377
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6063638
Reviewed-by: Anders Hartvoll Ruud \<[e-mail]>
Commit-Queue: Rune Lillesveen \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1390298}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=5cdd0c721bfe68fe4f86c9671a77aea9fa04cf05

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS : 1

Chrome

CRASH: 1

Safari

PASS : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9cf78c1064af
[wpt PR 49464] - TransformPositionArea() incorrectly assumed two-value input, a=testonly

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/9cf78c1064af