Closed Bug 1934697 Opened 2 months ago Closed 2 months ago

Please update the Log & Raw links to point to github instead of hg

Categories

(Webtools :: Searchfox, task)

task

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Sylvestre, Assigned: nicolas.guichard)

References

Details

Attachments

(1 file)

47 bytes, text/x-github-pull-request
Details | Review

it isn't going to change much but the hgweb is taking heavy load. So, let's point to github instead of hgweb for log & raw.
thanks

Summary: Please the Log & Raw link to point to github instead of hg → Please update the Log & Raw links to point to github instead of hg

(In reply to Sylvestre Ledru [:Sylvestre] from comment #0)

it isn't going to change much but the hgweb is taking heavy load. So, let's point to github instead of hgweb for log & raw.
thanks

Because of the invaluable extra info hg.mozilla.org adds to revisions about the push and the https://buildhub.moz.tools/ -esque info about first release with/last release without as well as the mercurial "follow these lines through time" powers, I don't think we can remove the hgweb "Log" link affordance, but it definitely makes sense to use github for "Raw" and provide the github history link (like https://github.com/mozilla/gecko-dev/commits/${gitrev}/${path} as the favored "Log". Then we could expose the existing hg log as "HG Log" after "Log" or maybe in its own (sub)section, depending on how people feel about the change to muscle memory for that and whether we can find a way to easily add buildhub links[1] (which would also go in the new section).

Nicolas, can you take a look at this? I believe from my notes in https://bugzilla.mozilla.org/show_bug.cgi?id=1890435#c0 that our revs are already hash compatible with gecko-dev. This could also be a good opportunity to make sure we do github links for the other relevant repos like requested for wubkat in bug 1847297 and address the issue link logic for LLVM in bug 1874757. Note that in bug 1847297 I proposed not including both hg and git links, but obviously this bug changes the rationale around that. The mozsearch index rust analysis search on the hg_root symbol works quite nicely (and the diagram is nice too, of course!).

1: Like, we can make URLs like https://buildhub.moz.tools/?q=source.revision%3A250be4ca3c669db9a397456402f68249aa15d8d5 but the revision needs to be something that taskcluster built (for m-c?) AFAICT from https://buildhub2.readthedocs.io/en/latest/project.html#overview but I don't know that searchfox can effectively know that without ingesting additional data. (And we would eventually want to ingest all that, but it's probably out of scope for now.)

Flags: needinfo?(nicolas.guichard)
Blocks: 1934104
Blocks: hg-to-git
No longer blocks: 1934104
No longer blocks: hg-to-git
See Also: → hg-to-git
Attached file GitHub Pull Request
Assignee: nobody → nicolas.guichard
Status: NEW → ASSIGNED
Flags: needinfo?(nicolas.guichard)

After discussion on #searchfox:mozilla.org this has been implemented as:

  • The “Raw” link is always replaced with a link to GitHub when available.
  • The “Log” link is renamed to “Mercurial log”.
  • A new “Git log” link is added above the “Mercurial log” link.
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: