Closed Bug 1934719 Opened 2 months ago Closed 2 months ago

Kanopy.com video thumbnail images are squished or missing

Categories

(Core :: Layout: Flexbox, defect)

defect

Tracking

()

RESOLVED DUPLICATE of bug 1936259
Tracking Status
firefox-esr115 --- unaffected
firefox-esr128 --- unaffected
firefox133 --- unaffected
firefox134 --- fixed
firefox135 --- fixed

People

(Reporter: cpeterson, Unassigned)

References

(Regression, )

Details

(Keywords: regression)

Attachments

(2 files)

Ting-Yu, I bisected this regression to this pushlog for your fix for flexbox bug 1926015:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a4434b7aabdac9a19413cbeff360c874bb138110&tochange=7df628ab162c87151d7783027905fa7950da76ef

Steps to reproduce

  1. Log into https://www.kanopy.com/. You will need a library card from a library that partners with Kanopy.
  2. Open the "Browse" and click "New Additions" or some other category.

Expected result

The page should show carousels with video thumbnail images. See the attached Fx 133 screenshot.

Actual result

The page loads with squished thumbnail images or missing thumbnails. See the attached Nightly 135 screenshot.

Flags: needinfo?(aethanyc)
Attached image Fx_133_screenshot.png
Attachment #9441179 - Attachment description: 133_screenshot.png → Fx_133_screenshot.png
Attachment #9441179 - Attachment filename: 133_screenshot.png → Fx_133_screenshot.png
Attachment #9441178 - Attachment description: 135_screenshot.png → Nightly_135_screenshot.png
Attachment #9441178 - Attachment filename: 135_screenshot.png → Nightly_135_screenshot.png

It would be great if there is a reduced testcase to help me investigate. Bug 1888262 is still open that looks similar to this bug.

I've got a Kanopy account (via my own library card) and can reproduce, and I'm happy to share access for debugging purposes.

For me at least, this does seem to be a heisen-bug where having devtools open seems to mostly fix the issue (presumably because we're insufficiently reflowing and incorrectly using a stale size of some sort; and the inspector or flex layout-devtools trigger the appropriate sorts of layout flushes).

Fortunately we've got a reduced testcase over on bug 1936259 that might be the same underlying issue as what we're hitting here...
[edit: fixed bug number typo]

See Also: → 1936259

My proposed patch in bug 1936259 fixed kanopy.com, too. I'll close this as a duplication.

Status: NEW → RESOLVED
Closed: 2 months ago
Duplicate of bug: 1936259
Flags: needinfo?(aethanyc)
Keywords: testcase-wanted
Resolution: --- → DUPLICATE
See Also: 1936259
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: