1934827 - Text-Fragments: Create Text Fragment from a range if there are other matches on the page

Status: RESOLVED FIXED

(Core :: DOM: Navigation, task)

Description

[Jan Jaeschke [:jjaschke]]

This bug is a follow-up to 1934825 and covers more complex cases for creating a text fragment from a range:

• Determine if it's impossible to create a text fragment because the context terms cannot be unique
• Select appropriate context terms which are short enough but point to the correct range

Comment 1

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 1934827, part 1 - Text Fragments: Find all matches for the input range in the document. r=farre!,avandolder

Comment 2

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 1934827, part 2 - Text Fragments: Implement range content cache. r=farre!,avandolder

This is a prerequisite commit and introduces a data structure that is used in the following patches.

This patch introduces a helper function that converts the content of a nsRange into a fold case string.
Furthermore, it introduces a hashmap-based cache, which keeps the fold case representations accessible by nsRange pointer.

Comment 3

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 1934827, part 3 - Text Fragments: Implement helper to identify common start and end sub strings. r=hsivonen!

This is a prerequisite commit which introduces helper algorithms required for the following patches.

Given two strings in fold case representation, the algorithms determine the common start or common end sub strings.

Comment 4

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 1934827, part 4 - Text Fragments: Introduce helper to log the state of a text directive candidate. r=avandolder!

This is a prerequisite commit for the following patches.

Comment 5

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 1934827, part 5 - Text Fragments: Implement algorithm to create text fragments which require expanding context terms. r=farre!,avandolder

This patch uses an iterative approach to identify valid context terms to ensure that a text directive points to the correct range:
For each candidate which would match the currently selected candidate, new candidates are created by extending each context term until the candidate does not match anymore.
Then, each of these candidates is matched against all remaining candidates to assess the quality of the candidate.
Then the candidate which has the smallest amount of matches is chosen as current candidate.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2a12d7d6dc3f
part 1 - Text Fragments: Find all matches for the input range in the document. r=farre
https://hg.mozilla.org/integration/autoland/rev/21b2f024f889
part 2 - Text Fragments: Implement range content cache. r=farre
https://hg.mozilla.org/integration/autoland/rev/883150cd2569
part 3 - Text Fragments: Implement helper to identify common start and end sub strings. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/b2ab060fe7e4
part 4 - Text Fragments: Introduce helper to log the state of a text directive candidate. r=avandolder
https://hg.mozilla.org/integration/autoland/rev/dd86e3d3e63a
part 5 - Text Fragments: Implement algorithm to create text fragments which require expanding context terms. r=farre

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/27296a2c825b
Fix build bustages. CLOSED TREE

Comment 8

[Sandor Molnar[:smolnar]]

Backed out for causing build bustages

Backout link: https://hg.mozilla.org/integration/autoland/rev/c758d2df5740085083ebe05782b46a40510f4f9b

Push with failures

Failure log -> /builds/worker/checkouts/gecko/xpcom/build/FileLocation.h:13:10: fatal error: FileUtils.h: No such file or directory

Failure log -> ERROR - /builds/worker/checkouts/gecko/dom/base/TextDirectiveCreator.cpp:468:12: error: local variable 'newCandidates' will be copied despite being returned by name [-Werror,-Wreturn-std-move]

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a660933d356
part 1 - Text Fragments: Find all matches for the input range in the document. r=farre
https://hg.mozilla.org/integration/autoland/rev/4d6a127a87d4
part 2 - Text Fragments: Implement range content cache. r=farre
https://hg.mozilla.org/integration/autoland/rev/47d12af58cc9
part 3 - Text Fragments: Implement helper to identify common start and end sub strings. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/bce86afcab54
part 4 - Text Fragments: Introduce helper to log the state of a text directive candidate. r=avandolder
https://hg.mozilla.org/integration/autoland/rev/f8857d2987af
part 5 - Text Fragments: Implement algorithm to create text fragments which require expanding context terms. r=farre

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/87a98810be58
An adittion for linux-base-toolchain. CLOSED TREE

Comment 11

[amarc]

https://hg.mozilla.org/mozilla-central/rev/3a660933d356
https://hg.mozilla.org/mozilla-central/rev/4d6a127a87d4
https://hg.mozilla.org/mozilla-central/rev/47d12af58cc9
https://hg.mozilla.org/mozilla-central/rev/bce86afcab54
https://hg.mozilla.org/mozilla-central/rev/f8857d2987af
https://hg.mozilla.org/mozilla-central/rev/87a98810be58