1934914 - On CSSScopeRule with `:scope` selector, CSSScopeRule#selectorMatchesElement(0, scopedElement) returns false

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

With the following HTML:

<footer id="scoped">
  <style>
    @scope {
      :scope {
        color: red;
      }
    }
  </style>
</footer>

executing scopedRule.selectorMatchesElement(0, document.querySelector("#scoped")) returns false.
I'm expecting it to return true as the rule does apply on the #scoped element.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: WIP: Bug 1934914 - [devtools] Add :scope test case in test_selectormatcheselement.html.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

I attached a patch which adds a failing assertion to demonstrate the issue.
David, would you know what's happening here?

Comment 3

[David Shin[:dshin]]

Right, need to handle this. Somewhere here we need to collect scoped rules as well as parent style rules, as well as ensuring that we're in scope.

Comment 4

[David Shin[:dshin]]

Attachment: Bug 1934914: Remove unused `stylist` param in `scope_condition_matches`. r=#style

Comment 5

[David Shin[:dshin]]

Attachment: Bug 1934914: Support @scope in CSSScopeRule#selectorMatchesElement. r=#style,#devtools-reviewers

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/20d9dd96cb8d
https://hg.mozilla.org/integration/autoland/rev/18192a2c7e42
Remove unused `stylist` param in `scope_condition_matches`. r=firefox-style-system-reviewers,emilio
https://github.com/mozilla-firefox/firefox/commit/5fd9ce062a67
https://hg.mozilla.org/integration/autoland/rev/2954a81e7a0b
Support @scope in CSSScopeRule#selectorMatchesElement. r=firefox-style-system-reviewers,devtools-reviewers,nchevobbe,emilio

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/18192a2c7e42
https://hg.mozilla.org/mozilla-central/rev/2954a81e7a0b