1934942 - Dismissing Edit Profile page closes Firefox window

Status: VERIFIED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Simona Badau, Desktop QA]

Found in

• Nightly 135.0a1

Affected versions

• Nightly 135.0a1

Tested platforms

• Affected platforms: Windows 11, macOS 15

Preconditions

• Set the pref "browser.profiles.enabled" to "true" in about:config and create Profile 1.

Steps to reproduce

1. Open the Profiles Panel and click the Edit button.
2. Close all other tabs, except for the "Edit profile" one.
3. On the Edit Profile page, change the theme and click the Done Editing button.

Expected result

• The Edit Profile page should close, but Firefox itself should remain open.

Actual result

• Clicking the Done Editing button closes the entire Firefox window. This is unexpected behavior, as the user only intended to dismiss the Edit Profile page, not to close Firefox.

Regression range

• This is not a regression; it's introduced with the Profile switcher feature.

Comment 1

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

It should be pretty easy to instead navigate to about:home if we're in the only tab / only window.

Comment 2

[Simona Badau, Desktop QA]

Jared, I noticed that the Firefox window is also dismissed when clicking on a profile card in the about:profilemanager tab (if it’s the only open tab). Should I file a new bug to cover this, or will it be addressed with this one?

Comment 3

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1934942 - Create new tab when closing a profiles tab if it is the only tab. r=#profiles-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e548825f91f0
Create new tab when closing a profiles tab if it is the only tab. r=profiles-reviewers,jhirsch

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e548825f91f0

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 7

[Simona Badau, Desktop QA]

Verified as fixed using Firefox 137.0b2 and Nightly 138.0a1 on macOS 15 and Windows 11 - a new tab is opened instead of the dismissed about page.