1935015 - enable lzma for macOS dmgs on beta and release

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Description

[[e-mail] (:bhearsum)]

In https://bugzilla.mozilla.org/show_bug.cgi?id=1880009 we've added support for, and enabled on Nightly, LZMA compression in macOS DMGs. We're holding this on Nightly for the moment while we monitor for any issues being reported, and changes to our attribution rate. When we're ready, we'll let it ride to Beta & Nightly.

I'm tentatively thinking that we'll have this flip on in Firefox 136, which heads to Beta on February 3rd, which would give it ~2 months on Nightly first.

Comment 1

[[e-mail] (:bhearsum)]

I had a look at the Nightly data today, and it looks to me like turning on lzma compression on Nightly has had no negative effects on mac attribution nor new profiles. attribution rate has largely stayed above 90%, with the occasional large dip (but this is a well established pattern at this point). Absolute attribution errors have been steady, with a dip that corresponds with the 2024 holiday season. New profiles have also stayed steady with a similar dip (as we saw around the same time last year).

Dave, would you like to do the honours of flipping this on?

Comment 2

[Dave Vasilevsky [:vasi]]

Sure! Should I leave the old dmg/dmg-attrib PACKAGE_FORMATS around, or get rid of them? I think this is their only use.

Comment 3

[[e-mail] (:bhearsum)]

(In reply to Dave Vasilevsky [:vasi] from comment #2)

Sure! Should I leave the old dmg/dmg-attrib PACKAGE_FORMATS around, or get rid of them? I think this is their only use.

They can go; we'll dig them up again if we ever need them. Thanks!

Comment 4

[Dave Vasilevsky [:vasi]]

Attachment: Bug 1935015 - Enable lzma for dmgs on beta/release

Comment 5

[Dave Vasilevsky [:vasi]]

Submitted a patch. I'm not sure why it's marked as WIP, how do I mark it as ready?

Comment 6

[Sylvestre Ledru [:Sylvestre]]

we wrote a blog post for xz https://blog.nightly.mozilla.org/2024/11/28/announcing-faster-lighter-firefox-downloads-for-linux-with-tar-xz-packaging/
should we do the same for this change?

Comment 7

[[e-mail] (:bhearsum)]

(In reply to Dave Vasilevsky [:vasi] from comment #5)

Submitted a patch. I'm not sure why it's marked as WIP, how do I mark it as ready?

Most likely, you need to add a reviewer to your commit message (I know taskgraph-reviewers is added automatically, but moz-phab is marking it as WIP before it even gets there...) If it's not that, it should tell you what the cause is on the command line.

Comment 8

[[e-mail] (:bhearsum)]

(In reply to [e-mail] (:bhearsum) from comment #7)

(In reply to Dave Vasilevsky [:vasi] from comment #5)

Submitted a patch. I'm not sure why it's marked as WIP, how do I mark it as ready?

Most likely, you need to add a reviewer to your commit message (I know taskgraph-reviewers is added automatically, but moz-phab is marking it as WIP before it even gets there...) If it's not that, it should tell you what the cause is on the command line.

This is more invisible than that (unless you're unpacking DMGs with something other than hdiutil/Finder, you won't notice), but it probably makes sense to anyways, yeah. I'll get that going.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/80079bc6abc1
Enable lzma for dmgs on beta/release r=taskgraph-reviewers,bhearsum

Comment 10

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/80079bc6abc1

Comment 11

[Pascal Chevrel:pascalc]

Ben, it looks like this is shipping in 136, should we move the nightly-only release note to our beta/release 136 notes?

Comment 12

[[e-mail] (:bhearsum)]

(In reply to Pascal Chevrel:pascalc from comment #11)

Ben, it looks like this is shipping in 136, should we move the nightly-only release note to our beta/release 136 notes?

We should!

Comment 13

[Donal Meehan [:dmeehan]]

Removed the release note under Bug 1880009 from the nightly only release notes in 136 and 137
Added to the 136 nightly and beta release notes
Keeping the relnote-firefox flag as ? to keep it on the radar for inclusion in the final Fx136 release notes.