1935081 - [wpt-sync] Sync PR 49516 - Fix failing WPTs introduced by https://crrev.com/c/5937916

Status: RESOLVED FIXED

(Core :: DOM: Editor, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 49516 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/49516
Details from upstream follow.

Utkarsh Pathak <[e-mail]> wrote:

Fix failing WPTs introduced by https://crrev.com/c/5937916

There are few failures introduced by WPT import in the editing component
where the editing includes insertHTML command alongwith the white-space
CSS properties. This CL fixes the failing WPTs by setting the
expectation as per the CSS specification linked below.

This change only updates the expectation for the failing WPTs which were
introduced by this[1] CL and seem to have wrong expectations.

[1] https://crrev.com/c/5937916
[2] https://www.w3.org/TR/css-text-3/#white-space-property

Bug: 373924023
Change-Id: I31f2e63275e986c37cc423c5b0c878296d8ee5a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5960541
Reviewed-by: Siye Liu \<[e-mail]>
Reviewed-by: Kent Tamura \<[e-mail]>
Commit-Queue: Utkarsh Pathak \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1391524}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=5bcf219df5c08ade774f7640f985a35ed5fd550f

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1531 subtests

Status Summary

Firefox

OK : 1
PASS: 1494
FAIL: 37

Chrome

OK : 1
PASS: 1471
FAIL: 60

Safari

OK : 1
PASS: 1463
FAIL: 68

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

• /editing/run/inserthtml.html [wpt.fyi]
  • [["inserthtml","abc"]] "<xmp>f[o]o</xmp>" compare innerHTML: FAIL linked bug:Bug 1916042
  • [["stylewithcss","true"],["inserthtml","<b>abc</b>"]] "<xmp>f[o]o</xmp>" compare innerHTML: FAIL linked bug:Bug 1916042
  • [["stylewithcss","false"],["inserthtml","<b>abc</b>"]] "<xmp>f[o]o</xmp>" compare innerHTML: FAIL linked bug:Bug 1916042

New Tests That Don't Pass

• /editing/run/inserthtml.html [wpt.fyi]
  • [["defaultparagraphseparator","div"],["inserthtml","<li>abc"]] "<p>foo[bar]baz" compare innerHTML: FAIL (Chrome: FAIL, Safari: FAIL)
  • [["defaultparagraphseparator","p"],["inserthtml","<li>abc"]] "<p>foo[bar]baz" compare innerHTML: FAIL (Chrome: FAIL, Safari: FAIL)
  • [["inserthtml","abc"]] "<xmp>f[o]o</xmp>" compare innerHTML: FAIL (Chrome: PASS, Safari: PASS)
  • [["stylewithcss","true"],["inserthtml","<b>abc</b>"]] "<xmp>f[o]o</xmp>" compare innerHTML: FAIL (Chrome: PASS, Safari: PASS)
  • [["stylewithcss","false"],["inserthtml","<b>abc</b>"]] "<xmp>f[o]o</xmp>" compare innerHTML: FAIL (Chrome: PASS, Safari: PASS)
  • [["stylewithcss","true"],["inserthtml","<b>abc</b>"]] "<script>f[o]o</script>bar" compare innerHTML: FAIL (Chrome: FAIL, Safari: FAIL)
  • [["stylewithcss","false"],["inserthtml","<b>abc</b>"]] "<script>f[o]o</script>bar" compare innerHTML: FAIL (Chrome: FAIL, Safari: FAIL)
  • [["inserthtml","<dt>abc</dt>"]] "<dl><dt>f[o]o<dd>bar</dl>" compare innerHTML: FAIL (Chrome: FAIL, Safari: FAIL)
  • [["inserthtml","<dt>abc</dt>"]] "f[o]o" compare innerHTML: FAIL (Chrome: FAIL, Safari: FAIL)
  • [["inserthtml","<dt>abc</dt>"]] "<ol><li>f[o]o</ol>" compare innerHTML: FAIL (Chrome: FAIL, Safari: FAIL)
  • [["inserthtml","<dd>abc</dd>"]] "f[o]o" compare innerHTML: FAIL (Chrome: FAIL, Safari: FAIL)
  • [["inserthtml","<dd>abc</dd>"]] "<ol><li>f[o]o</ol>" compare innerHTML: FAIL (Chrome: FAIL, Safari: FAIL)
  • [["inserthtml","<ol><li>abc</ol>"]] "<dir><li>f[o]o</dir>" compare innerHTML: FAIL (Chrome: FAIL, Safari: FAIL)
  • [["inserthtml","<ol><li>abc</ol>"]] "<ol><li>f[o]o</ol>" compare innerHTML: FAIL (Chrome: FAIL, Safari: FAIL)
  • [["inserthtml","<ol><li>abc</ol>"]] "<ul><li>f[o]o</ul>" compare innerHTML: FAIL (Chrome: FAIL, Safari: FAIL)
  • [["inserthtml","<ul><li>abc</ul>"]] "<dir><li>f[o]o</dir>" compare innerHTML: FAIL (Chrome: FAIL, Safari: FAIL)
  • [["inserthtml","<ul><li>abc</ul>"]] "<ol><li>f[o]o</ol>" compare innerHTML: FAIL (Chrome: FAIL, Safari: FAIL)
  • [["inserthtml","<ul><li>abc</ul>"]] "<ul><li>f[o]o</ul>" compare innerHTML: FAIL (Chrome: FAIL, Safari: FAIL)
  • [["defaultparagraphseparator","div"],["inserthtml","<li>abc</li>"]] "f[o]o" compare innerHTML: FAIL (Chrome: FAIL, Safari: FAIL)
  • [["defaultparagraphseparator","p"],["inserthtml","<li>abc</li>"]] "f[o]o" compare innerHTML: FAIL (Chrome: FAIL, Safari: FAIL)
  • [["stylewithcss","true"],["defaultparagraphseparator","div"],["inserthtml","<p>abc"]] "<font color=blue>foo[]bar</font>" compare innerHTML: FAIL (Chrome: FAIL, Safari: FAIL)
  • [["stylewithcss","false"],["defaultparagraphseparator","div"],["inserthtml","<p>abc"]] "<font color=blue>foo[]bar</font>" compare innerHTML: FAIL (Chrome: FAIL, Safari: FAIL)
  • [["stylewithcss","true"],["defaultparagraphseparator","p"],["inserthtml","<p>abc"]] "<font color=blue>foo[]bar</font>" compare innerHTML: FAIL (Chrome: FAIL, Safari: FAIL)
  • [["stylewithcss","false"],["defaultparagraphseparator","p"],["inserthtml","<p>abc"]] "<font color=blue>foo[]bar</font>" compare innerHTML: FAIL (Chrome: FAIL, Safari: FAIL)
  • [["stylewithcss","true"],["defaultparagraphseparator","div"],["inserthtml","<p>abc"]] "<span style=color:blue>foo[]bar</span>" compare innerHTML: FAIL (Chrome: FAIL, Safari: FAIL)
  • [["stylewithcss","false"],["defaultparagraphseparator","div"],["inserthtml","<p>abc"]] "<span style=color:blue>foo[]bar</span>" compare innerHTML: FAIL (Chrome: FAIL, Safari: FAIL)
  • [["stylewithcss","true"],["defaultparagraphseparator","p"],["inserthtml","<p>abc"]] "<span style=color:blue>foo[]bar</span>" compare innerHTML: FAIL (Chrome: FAIL, Safari: FAIL)
  • [["stylewithcss","false"],["defaultparagraphseparator","p"],["inserthtml","<p>abc"]] "<span style=color:blue>foo[]bar</span>" compare innerHTML: FAIL (Chrome: FAIL, Safari: FAIL)
  • [["inserthtml"," "]] "<p>[foo]</p>" compare innerHTML: FAIL (Chrome: FAIL, Safari: FAIL)
  • [["stylewithcss","true"],["inserthtml","<span style=display:none></span>"]] "<p>[foo]</p>" compare innerHTML: FAIL (Chrome: PASS, Safari: FAIL)
  • [["stylewithcss","false"],["inserthtml","<span style=display:none></span>"]] "<p>[foo]</p>" compare innerHTML: FAIL (Chrome: PASS, Safari: FAIL)
  • [["inserthtml","abc"]] "<p><!--foo-->{}<span><br></span><!--bar--></p>" compare innerHTML: FAIL (Chrome: FAIL, Safari: FAIL)
  • [["inserthtml","<!--abc-->"]] "<p><!--foo-->{}<span><br></span><!--bar--></p>" compare innerHTML: FAIL (Chrome: FAIL, Safari: FAIL)
  • [["inserthtml","abc"]] "<p>{}<span><!--foo--><br><!--bar--></span></p>" compare innerHTML: FAIL (Chrome: FAIL, Safari: FAIL)
  • [["inserthtml","<!--abc-->"]] "<p>{}<span><!--foo--><br><!--bar--></span></p>" compare innerHTML: FAIL (Chrome: FAIL, Safari: FAIL)
  • [["inserthtml","<!--abc-->"]] "<p><!--foo--><span><br></span>{}<!--bar--></p>" compare innerHTML: FAIL (Chrome: FAIL, Safari: FAIL)
  • [["inserthtml","<!--abc-->"]] "<p><span><!--foo--><br><!--bar--></span>{}</p>" compare innerHTML: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5468b94323f7
[wpt PR 49516] - Fix failing WPTs introduced by https://crrev.com/c/5937916, a=testonly
https://hg.mozilla.org/integration/autoland/rev/b9e191cee38f
[wpt PR 49516] - Update wpt metadata, a=testonly

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/5468b94323f7
https://hg.mozilla.org/mozilla-central/rev/b9e191cee38f