1935122 - Serde v1.0.215 produces warnings in Marionette crate because multiple variants have the same deserialization name

Status: RESOLVED FIXED

(Testing :: geckodriver, defect, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Serde got upgraded to v1.0.215: https://github.com/serde-rs/serde/releases/tag/v1.0.215

But with the following change it will break the cargo to build geckodriver (see bug 1933492 comment 11):

Produce warning when multiple fields or variants have the same deserialization name

We have to refactor the affected code so that we have only one variant for each deserialization name.

Here the list of warnings that I can see:

warning: unreachable pattern
   --> testing/geckodriver/marionette/src/webdriver.rs:254:22
    |
254 |     #[serde(rename = "WebDriver:FindElement")]
    |                      ^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `#[warn(unreachable_patterns)]` on by default

warning: unreachable pattern
   --> testing/geckodriver/marionette/src/webdriver.rs:260:22
    |
260 |     #[serde(rename = "WebDriver:FindElements")]
    |                      ^^^^^^^^^^^^^^^^^^^^^^^^

warning: unreachable pattern
   --> testing/geckodriver/marionette/src/webdriver.rs:364:22
    |
364 |     #[serde(rename = "WebDriver:TakeScreenshot")]
    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: unreachable pattern
   --> testing/geckodriver/marionette/src/webdriver.rs:366:22
    |
366 |     #[serde(rename = "WebDriver:TakeScreenshot")]
    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^

Comment 1

[James Graham [:jgraham]]

Attachment: Bug 1935122 - Ensure we have one command variant per marionette command,

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/183b78bba4ee
Ensure we have one command variant per marionette command, r=webdriver-reviewers,whimboo

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/183b78bba4ee