1935178 - Add a test for Tab keyboard navigation

Status: RESOLVED FIXED

(DevTools :: Shared Components, task)

Description

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Active Rules view, focus indicator is displayed on Layout tab

See screenshot
The focus indicator should only really be visible on the active tab, since using the Tab key will move outside of the tab strip, and the arrow keys can be used to select the next/previous tab automatically

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

This was regressed by Bug 1810427. I'm going to investigate

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1810427

:ff2400t, since you are the author of the regressor, bug 1810427, could you take a look?

For more information, please visit BugBot documentation.

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1935178 - [devtools] Add test for Tabs keyboard navigation. r=#devtools.

Use data-tab-index attribute instead of is-active class in selector.
Add test case to check that the keyboard shortcut does work and moves
the focus to the appropriate tab.

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1935178 - [devtools] Prevent :focus-visible style to be applied on Tabs when they're clicked. r=#devtools.

We're doing something similar in the markup view already.

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Bug 1810427 was backed out, but let's keep this bug to add a test

Comment 6

[Phabricator Automation]

Comment on attachment 9442156 [details]
Bug 1935178 - [devtools] Prevent :focus-visible style to be applied on Tabs when they're clicked. r=#devtools.

Revision D231391 was moved to bug 1936201. Setting attachment 9442156 [details] to obsolete.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60c45c17a7c4
[devtools] Add test for Tabs keyboard navigation. r=devtools-reviewers,ochameau.

Comment 8

[amarc]

https://hg.mozilla.org/mozilla-central/rev/60c45c17a7c4