Closed Bug 1935344 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 49538 - Take value phase into account for computed inset properties

Categories

(Core :: CSS Parsing and Computation, task, P4)

task

Tracking

()

RESOLVED FIXED
135 Branch
Tracking Status
firefox135 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 49538 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/49538
Details from upstream follow.

Rune Lillesveen <futhark@chromium.org> wrote:

Take value phase into account for computed inset properties

ValueForPositionOffset incorrectly returned the resolved value for the
computed value phase. computedStyleMap() already worked correctly
because we always pass in a null LayoutObject for that API. But for
computing end points for discrete transitions it was wrong.

This also fixes a crash when updating inset transitions for fallback
style updates during layout for anchor positioning. We were trying to
resolve an 'auto' value based on the layout result of an abspos while
laying out the very same abspos.

Bug: 382294236, 379758203
Change-Id: If8cf363766c8a87f344b9143342cafa26942fb17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6072802
Commit-Queue: Rune Lillesveen \<futhark@chromium.org>
Reviewed-by: Anders Hartvoll Ruud \<andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1392165}

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

PASS : 2

Chrome

CRASH: 1
FAIL : 1

Safari

PASS : 2

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d4603028e2ad [wpt PR 49538] - Take value phase into account for computed inset properties, a=testonly
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 135 Branch
You need to log in before you can comment on or make changes to this bug.